Add functions with dims keyword argument

[martinholters]

Add (unexported) Compat.accumulate, Compat.accumulate!,
Compat.all, Compat.any, Compat.cor, Compat.cov,
Compat.cumprod, Compat.cumprod!, Compat.cumsum, Compat.cumsum!,
Compat.findmax, Compat.findmin, Compat.mapreduce,
Compat.maximum, Compat.mean, Compat.median, Compat.minimum,
Compat.prod, Compat.reduce, Compat.sort, Compat.std,
Compat.sum, Compat.var, and Compat.varm with dims keyword
argument.

[martinholters]

If we wait for JuliaLang/julia#26521, I can put the commented tests behind VERSION conditionals, exempting only the version range where Julia was broken. (Of course, we can also merge this now and fix up the tests later.)

[fredrikekre]

I added the version check. I didn't verify this, but you implied in the julia issue that it was broken by JuliaLang/julia#25989?

[fredrikekre]

I guess these @eval could be removed? Only the ones in the loops over function symbols is needed AFAICT.

[martinholters]

Good catch. I'll update.

[martinholters]

Um, no, that gives

ERROR: LoadError: error compiling anonymous: error in method definition: function Base.accumulate! must be explicitly imported to be extended

There is no other use accumulate! though, so why doesn't it just create a new binding to a new function? BUT if I move the definition to its own if block, it does work without the @eval. Strange...

[fredrikekre]

Yea I tried the same, lets just leave it as is I guess.

[martinholters]

Heh, seems to be some Julia issue on 0.6, but is fixed on master:

julia> module M1
           if true
               identity(x) = Base.identity(x)
           end
       end
M1

julia> module M2
           if true
               for f in (:a, :b); end
               identity(x) = Base.identity(x)
           end
       end
ERROR: error compiling anonymous: error in method definition: function Base.identity must be explicitly imported to be extended

[martinholters]

I added the version check.

Thanks, but I've actually bisected the origin to an earlier change; the correct lower bound would have to be v"0.7.0-DEV.3262". I'll update accordingly.

[martinholters]

Go to go from my side (if CI agrees), but I'm not sure the last commit is a net gain. Keep it or drop it?