Merged
Conversation
b87ce71 to
c72aa67
Compare
Contributor
|
There is a small bash-3.2$ find . -name CMakeLists.txt | xargs cmake-lint
./example/CommandLineModule/CMakeLists.txt
==========================================
./example/CMakeLists.txt
========================
./example/SharedLibrary/CMakeLists.txt
======================================
./example/CommandLine/CMakeLists.txt
====================================
./example/WindowsApplication/CMakeLists.txt
===========================================
./example/WindowsApplication/CMakeLists.txt:14: [C0304] Final newline missing
Summary
=======
files scanned: 5
found lint:
Convention: 1
bash-3.2$ |
Owner
Author
|
Thanks for taking a look, @ClausKlein. It turns out that my script was only linting |
515555d to
7dd8cd4
Compare
7dd8cd4 to
a34d833
Compare
InCom-0
pushed a commit
to InCom-0/cmake_WindowsToolchain
that referenced
this pull request
Mar 10, 2026
InCom-0
pushed a commit
to InCom-0/cmake_WindowsToolchain
that referenced
this pull request
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes WindowsToolchain strictly just a CMake Toolchain, based on discussion #65. This reduces the surface area of the project, and as a result addresses #50 and most of #18 (moving and renaming files is still a discussion to have). I won't commit this until I've figured out where the other pieces land, but it seems useful to send this out to understand what a pure Toolchain would be.
This also removes the support for downloading VSWhere.exe if it can't be found. The Official documentation for finding Visual Studio instances enumerates the ways to find Visual Studio - including vswhere.exe - but never makes the statement that you can rely on the installation location of vswhere.exe. As a result, I added support for downloading vswhere.exe from an official distribution mechanism. I have since discovered (/noticed ;) that the VSWhere documentation does say that VSWhere should be found under
%ProgramFiles(x86)%\Microsoft Visual Studio\Installer\vswhere.exe, so I am going to rely on that.