Skip to content

Fix ComboBox popup location#1963

Merged
Keboo merged 2 commits intoMaterialDesignInXAML:masterfrom
bombipappoo:fix-combobox-popup
Sep 14, 2020
Merged

Fix ComboBox popup location#1963
Keboo merged 2 commits intoMaterialDesignInXAML:masterfrom
bombipappoo:fix-combobox-popup

Conversation

@bombipappoo
Copy link
Copy Markdown
Contributor

Fixes #1949

To find the location of the popup, set HorizontalOffset to 0 and use only the newly added RelativeHorizontalOffset property.

In addition,

  • Fixes the clear button is a bit bigger than TextBlock.
  • Specified the background color at the bottom of PopupContentUpTemplate.
  • Fixes VisiblePlacementWidth when FlowDirection is RightToLeft.
  • Unfortunately, it may not work when DPI is greater than 100%.

@Keboo Keboo added the evaluation required Items is pending review or evaluation by the team label Jul 10, 2020
@Keboo
Copy link
Copy Markdown
Member

Keboo commented Jul 10, 2020

Need to test this on more DPIs. If anyone is interested in helping test this, please post results here.

@bombipappoo bombipappoo mentioned this pull request Sep 7, 2020
@greuelpirat
Copy link
Copy Markdown
Contributor

greuelpirat commented Sep 7, 2020

I made some tests with the example from #916

100 %

image --> image

125 %

image --> image

150 %

image --> image

175 %

image --> image

200 %

image --> image

seems good to me 👍

this also fixes #1684

@Keboo Keboo added this to the 3.2.0 milestone Sep 14, 2020
@Keboo Keboo merged commit f90f160 into MaterialDesignInXAML:master Sep 14, 2020
@bombipappoo bombipappoo deleted the fix-combobox-popup branch September 16, 2020 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

evaluation required Items is pending review or evaluation by the team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ComboBox issue

4 participants