Merged
Conversation
Rebase, CI won't work otherwise.
jonasteuwen
reviewed
Jun 28, 2021
Contributor
|
At the line where you want to disable it.
… On 28 Jun 2021, at 11:36, George Yiasemis ***@***.***> wrote:
@georgeyiasemis commented on this pull request.
In direct/common/subsample.py:
> +# pylint: disable = E1123
+
Where should it be? End of file?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Reviewing pull request
Contributor
|
There is too much ;-)
… On 28 Jun 2021, at 14:15, George Yiasemis ***@***.***> wrote:
@georgeyiasemis commented on this pull request.
In direct/data/datasets.py:
> + filenames = ["sample"]
+
+ if isinstance(filenames, str):
+ filenames = [filenames]
+
+ if len(filenames) != self.sample_size:
+ filenames = [filenames[0] + f"{_:05}" for _ in range(1, self.sample_size + 1)]
+
+ current_slice_number = 0
+ for idx, filename in enumerate(filenames):
+
+ if len(filenames) < 5 or idx % (len(filenames) // 5) == 0 or len(filenames) == (idx + 1):
+ self.logger.info(f"Parsing: {(idx + 1) / len(filenames) * 100:.2f}%.")
+
+ num_slices = self.spatial_shape[0] if len(self.spatial_shape) == 3 else 1
+
Insert or remove whitespace?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
…into remove-named-tensors
jonasteuwen
added a commit
that referenced
this pull request
Jul 13, 2021
* Remove named tensors * Delete projects/fastmri directory * Minor transforms fixes * Improve documentation * Add synthetic dataset * Update pytorch version * Improve mypy support * Improve pylint support * Code cleanup Co-authored-by: Jonas Teuwen <j.teuwen@nki.nl> Co-authored-by: George Yiasemis <georgeyiasemis.hotmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes to use with no named tensors. Updates are only within direct/data and direct/nn directories.
Validation on calgary-campinas data from checkpoints match with stored metrics. Training also works fine.
@jonasteuwen can you please review?