Skip to content

Remove named tensors#103

Merged
jonasteuwen merged 78 commits intomainfrom
remove-named-tensors
Jun 29, 2021
Merged

Remove named tensors#103
jonasteuwen merged 78 commits intomainfrom
remove-named-tensors

Conversation

@georgeyiasemis
Copy link
Copy Markdown
Contributor

@georgeyiasemis georgeyiasemis commented Jun 14, 2021

Changes to use with no named tensors. Updates are only within direct/data and direct/nn directories.
Validation on calgary-campinas data from checkpoints match with stored metrics. Training also works fine.
@jonasteuwen can you please review?

@jonasteuwen
Copy link
Copy Markdown
Contributor

jonasteuwen commented Jun 28, 2021 via email

@jonasteuwen
Copy link
Copy Markdown
Contributor

jonasteuwen commented Jun 28, 2021 via email

Copy link
Copy Markdown
Contributor

@jonasteuwen jonasteuwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonasteuwen jonasteuwen merged commit fa63ac3 into main Jun 29, 2021
@jonasteuwen jonasteuwen deleted the remove-named-tensors branch June 29, 2021 13:24
jonasteuwen added a commit that referenced this pull request Jul 13, 2021
* Remove named tensors
* Delete projects/fastmri directory
* Minor transforms fixes
* Improve documentation
* Add synthetic dataset
* Update pytorch version
* Improve mypy support
* Improve pylint support
* Code cleanup

Co-authored-by: Jonas Teuwen <j.teuwen@nki.nl>
Co-authored-by: George Yiasemis <georgeyiasemis.hotmail.com>
@jonasteuwen jonasteuwen restored the remove-named-tensors branch July 13, 2021 20:41
@jonasteuwen jonasteuwen deleted the remove-named-tensors branch July 13, 2021 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci docker documentation Improvements or additions to documentation python

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants