Skip to content

Fix high memory consumption and code quality improvements#174

Merged
jonasteuwen merged 63 commits intomainfrom
fix-high-memory-consumption
Feb 10, 2022
Merged

Fix high memory consumption and code quality improvements#174
jonasteuwen merged 63 commits intomainfrom
fix-high-memory-consumption

Conversation

@georgeyiasemis
Copy link
Copy Markdown
Contributor

@georgeyiasemis georgeyiasemis commented Feb 10, 2022

What's changed:

Co-authored:

jonasteuwen and others added 30 commits January 10, 2022 11:06
@jonasteuwen
Improve code quality (#158, #166)
811b0d7 
* Reduce pylint warnings
* Reduce pyflakes warnings
* Add codacy code quality badge
* Improving code quality by renaming variables
* Bump version: 1.0.0 → 1.0.1-dev0
* Do not run codecov/patch
@wdika
Adds citation button (#169)
43543b5 
Co-authored-by: wdika <dimitriskarkalousos@gmail.com>
@georgeyiasemis
Update model_zoo.rst
d874e8d
@georgeyiasemis
Fix linter errors (#170)
ce060aa 
* Fix some linter warnings
* Add .prospector.yml
* Update docs/index.rst
@georgeyiasemis
Delete README.md
94798c3
@georgeyiasemis
Update README.rst
0d21936
@georgeyiasemis
Merged MRI models engine to MRIModelEngine
a851dd6
@georgeyiasemis
Minor fix
db27833
@georgeyiasemis
Func to get size of objiect
7f112c9
@jonasteuwen
- Fix typo
ea86805 
- Refactor to have functions not class members
@jonasteuwen
- Remove process_output from base class
4d6956f
@jonasteuwen
First attempt to rewriting validation process (will not pass CI)
0834a7e
@jonasteuwen
Rewrite validation process (will not pass CI)
5aded01
@jonasteuwen
Improve validation
0723e7b
@jonasteuwen
Improve validation
fe5851d
@jonasteuwen
Log metric output
abedab2
@jonasteuwen
Improve metric log output
7c62208
@jonasteuwen
Replace ISMRMD with xml parser
3e3b7f3
@jonasteuwen
Make sure the metric is cloned
7f6a440
@jonasteuwen
Refactoring
8fe7471
@jonasteuwen
Refactoring
88565bf
@jonasteuwen
Refactoring
c951370
@jonasteuwen
Fix roll test
94c2713
@jonasteuwen
Remove is_validation_process
d4d8aba
@jonasteuwen
Move ismrmrd dependency to dev dependencies
ab82e36
@jonasteuwen
Install extras for tox
ee2145e
@georgeyiasemis
Make compatible tests for new updates
960529a
@georgeyiasemis
Minor fix
5f874f3
@georgeyiasemis
Fix pytest warning
ee47f0b
@georgeyiasemis
Fix pylint errors
46a0e12
@github-actions github-actions bot added ci documentation Improvements or additions to documentation python labels Feb 10, 2022
@jonasteuwen jonasteuwen merged commit e430521 into main Feb 10, 2022
@jonasteuwen jonasteuwen deleted the fix-high-memory-consumption branch February 10, 2022 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jonasteuwen jonasteuwen Awaiting requested review from jonasteuwen

Assignees

No one assigned

Labels

ci documentation Improvements or additions to documentation python

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

High memory consumption during validation Current stochasticity is not completely disabled

3 participants

@georgeyiasemis @jonasteuwen @wdika