reporting: factor up defcon calculation#1581
Merged
leondz merged 2 commits intoNVIDIA:mainfrom Feb 4, 2026
Merged
Conversation
leondz
added
the
reporting
erickgalinkin
approved these changes
Feb 2, 2026
Collaborator
erickgalinkin
left a comment
erickgalinkin
left a comment
There was a problem hiding this comment.
Would probably be good to have some kind of error handling in case an invalid enum isn't passed ("bounds doesn't have .TERRIBLE" or something) but otherwise LGTM.
Collaborator
Author
|
Yeah, I had a similar feeling. Maybe this can be expressed in a test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
implement notes in #1579:
calibration.defcon_and_comment()andreport_digest.map_absolute_score()and have a single score-to-defcon map function referencing a boundary class fromanalyze.__init__to avoid circular imports, esp. btw
report_digestandcalibration, the mapping fun is in__init__(where the constants its used with are also found)Also prune some dead/unaccessed code