Skip to content

python313Packages.stanza: modernize and remove dependencies#491614

Merged
SuperSandro2000 merged 2 commits intoNixOS:masterfrom
Stebalien:steb/modernize-stanza
Feb 19, 2026
Merged

python313Packages.stanza: modernize and remove dependencies#491614
SuperSandro2000 merged 2 commits intoNixOS:masterfrom
Stebalien:steb/modernize-stanza

Conversation

@Stebalien
Copy link
Contributor

@Stebalien Stebalien commented Feb 18, 2026 •
edited
Loading

This PR switches to pyproject and uses finalAttrs instead of a recursive attribute set. I've also added myself as a co-maintainer at @riotbib's request.

Additionally, it removes the following dependencies:

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

@Stebalien Stebalien force-pushed the steb/modernize-stanza branch 2 times, most recently from 33e3b6f to 8d66dbb Compare February 18, 2026 04:12
@Stebalien Stebalien changed the title python313Packages.stanza: modernize and update dependencies python313Packages.stanza: modernize and remove dependencies Feb 18, 2026
@Stebalien Stebalien requested a review from riotbib February 18, 2026 04:13
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 6.topic: python Python is a high-level, general-purpose programming language. labels Feb 18, 2026
@fabaff
Copy link
Member

fabaff commented Feb 18, 2026

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 491614
Commit: 8d66dbb520b7381c811985e1934311a8faf41dff

x86_64-linux

❌ 2 packages failed to build:
  • python313Packages.cltk
  • python313Packages.cltk.dist
✅ 20 packages built:
  • libretranslate (python313Packages.libretranslate)
  • libretranslate.dist (python313Packages.libretranslate.dist)
  • python313Packages.argos-translate-files
  • python313Packages.argos-translate-files.dist
  • python313Packages.argostranslate
  • python313Packages.argostranslate.dist
  • python313Packages.stanza
  • python313Packages.stanza.dist
  • python313Packages.translatehtml
  • python313Packages.translatehtml.dist
  • python314Packages.argos-translate-files
  • python314Packages.argos-translate-files.dist
  • python314Packages.argostranslate
  • python314Packages.argostranslate.dist
  • python314Packages.libretranslate
  • python314Packages.libretranslate.dist
  • python314Packages.stanza
  • python314Packages.stanza.dist
  • python314Packages.translatehtml
  • python314Packages.translatehtml.dist

@Stebalien
Copy link
Contributor Author

Stebalien commented Feb 18, 2026

I can't reproduce the cltk build failure locally (nix build -L '.#python313Packages.cltk'.

@Stebalien
python313Packages.stanza: modernize and remove dependencies
2a52e41 
Switch to pyproject and use `finalAttrs` instead of a recursive
attribute set. Additionally, remove the following dependencies:

- toml: stanza will use tomllib when available (added in python 3.11), which
appears to be the minimum supported cpython in nix.
- six: upstream no longer requires six.
@Stebalien
Copy link
Contributor Author

Stebalien commented Feb 18, 2026

Ah, I can reproduce with nixpkg-review. This seems to be related to #491060, so I'm trying a rebase.

@Stebalien Stebalien force-pushed the steb/modernize-stanza branch from 8d66dbb to 5662d96 Compare February 18, 2026 16:32
@riotbib
Copy link
Member

riotbib commented Feb 18, 2026

Hi @Stebalien, thanks a lot for your work on this. That really is appreciated.

I'm kinda out of capacity right now because of my day job. If you want we can share maintainership, or you adopt it.

@Stebalien Stebalien force-pushed the steb/modernize-stanza branch from 5662d96 to 2a52e41 Compare February 18, 2026 16:36
@Stebalien
Copy link
Contributor Author

Stebalien commented Feb 18, 2026

I'm not a heavy user of this package (I'm just trying to get libretranslate into better shape), but I'm happy to share maintainership, at least until someone more invested in this package comes along.

@Stebalien
Copy link
Contributor Author

Stebalien commented Feb 18, 2026

Ah, I can reproduce with nixpkg-review. This seems to be related to #491060, so I'm trying a rebase.

Nope, it still fails. It looks like that PR broke https://hydra.nixos.org/build/321967805.

@Stebalien
Copy link
Contributor Author

Stebalien commented Feb 18, 2026

#491816

@Stebalien
Copy link
Contributor Author

Stebalien commented Feb 18, 2026

Waiting on #491824

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Feb 19, 2026
@SuperSandro2000 SuperSandro2000 added this pull request to the merge queue Feb 19, 2026
@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Feb 19, 2026

Link to currently reviewing PR:
#491614
--------- Report for 'x86_64-linux' ---------
20 packages built:
libretranslate libretranslate.dist python313Packages.argos-translate-files python313Packages.argos-translate-files.dist python313Packages.argostranslate python313Packages.argostranslate.dist python313Packages.stanza python313Packages.stanza.dist python313Packages.translatehtml python313Packages.translatehtml.dist python314Packages.argos-translate-files python314Packages.argos-translate-files.dist python314Packages.argostranslate python314Packages.argostranslate.dist python314Packages.libretranslate python314Packages.libretranslate.dist python314Packages.stanza python314Packages.stanza.dist python314Packages.translatehtml python314Packages.translatehtml.dist

Logs can be found under:
/home/runner/.cache/nixpkgs-review/pr-491614/logs

x86_64-linux

❌ 2 packages failed to build:
  • python313Packages.cltk
  • python313Packages.cltk.dist
✅ 20 packages built:
  • libretranslate (python313Packages.libretranslate)
  • libretranslate.dist (python313Packages.libretranslate.dist)
  • python313Packages.argos-translate-files
  • python313Packages.argos-translate-files.dist
  • python313Packages.argostranslate
  • python313Packages.argostranslate.dist
  • python313Packages.stanza
  • python313Packages.stanza.dist
  • python313Packages.translatehtml
  • python313Packages.translatehtml.dist
  • python314Packages.argos-translate-files
  • python314Packages.argos-translate-files.dist
  • python314Packages.argostranslate
  • python314Packages.argostranslate.dist
  • python314Packages.libretranslate
  • python314Packages.libretranslate.dist
  • python314Packages.stanza
  • python314Packages.stanza.dist
  • python314Packages.translatehtml
  • python314Packages.translatehtml.dist

Merged via the queue into NixOS:master with commit 10f1f07 Feb 19, 2026
31 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@riotbib riotbib Awaiting requested review from riotbib

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Stebalien @fabaff @riotbib @SuperSandro2000