python3Packages.spacy: remove typer-slim from the required deps#491824
Closed
Stebalien wants to merge 1 commit intoNixOS:masterfrom
Closed
python3Packages.spacy: remove typer-slim from the required deps#491824Stebalien wants to merge 1 commit intoNixOS:masterfrom
Stebalien wants to merge 1 commit intoNixOS:masterfrom
Conversation
`typer-slim` was replaced by `typer` in NixOS#491060 but spaCy the check wants a wheel named `typer-slim`, which we don't provide. We can remove this once upstream removes the dependency on `typer-slim`. Fixes NixOS#491816
13 tasks
Contributor
|
Thank you. I filed #491832 to fix this. |
Contributor
Author
|
Yeah, that's probably the better approach. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
typer-slimwas replaced bytyperin #491060 but spaCy the check wants a wheel namedtyper-slim, which we don't provide. We can remove this once upstream removes the dependency ontyper-slim.Fixes #491816
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.