[15.0][FIX] queue_job: Add base_sparse_field dependency to prevent errors in test if addon not loaded. #451
Conversation
…n test if addon not loaded. TT35938
|
Hi @guewen, |
|
This PR has the |
|
/ocabot merge patch |
simahawk
left a comment
simahawk
left a comment
There was a problem hiding this comment.
Are you sure we need this on v15?
| (...) | ||
| workers = 6 | ||
| server_wide_modules = web,queue_job | ||
| server_wide_modules = web,queue_job,base_sparse_field |
There was a problem hiding this comment.
IMO this is not needed when the fields is imported from the module like in v14 https://github.com/OCA/queue/blob/14.0/queue_job/models/queue_job.py#L12 and is not needed at all on v15 AFAIK since a custom field is used instead https://github.com/OCA/queue/blob/15.0/queue_job/fields.py#L14
Am I missing anything?
There was a problem hiding this comment.
On v14 was needed for sure. If not, we got this error:
For v15 indeed the sparse field is gone, so we can close this.
Thanks for being aware of it.
There was a problem hiding this comment.
Welcome :)
I'll comment on the v14 PR for the other detail.
|
What a great day to merge this nice PR. Let's do it! |
|
@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 15.0-ocabot-merge-pr-451-by-pedrobaeza-bump-patch. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
|
I canceled the build for the merge while waiting for an answer 😉 |
5 participants
FWP from 14.0: #443
Add
base_sparse_fielddependency to prevent errors in test if addon not loaded. https://github.com/OCA/queue/blob/14.0/queue_job/models/queue_job.py#L12Please @pedrobaeza can you review it?
@Tecnativa TT35938