Skip to content

[15.0][FIX] queue_job: Add base_sparse_field dependency to prevent errors in test if addon not loaded. #451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
victoralmau wants to merge 1 commit into from
Closed

[15.0][FIX] queue_job: Add base_sparse_field dependency to prevent errors in test if addon not loaded. #451

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion queue_job/README.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ Configuration
[options]
(...)
workers = 6
server_wide_modules = web,queue_job
server_wide_modules = web,queue_job,base_sparse_field
Copy link
Contributor

@simahawk simahawk Aug 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO this is not needed when the fields is imported from the module like in v14 https://github.com/OCA/queue/blob/14.0/queue_job/models/queue_job.py#L12 and is not needed at all on v15 AFAIK since a custom field is used instead https://github.com/OCA/queue/blob/15.0/queue_job/fields.py#L14

Am I missing anything?

Copy link
Member

@pedrobaeza pedrobaeza Aug 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On v14 was needed for sure. If not, we got this error:

imagen

For v15 indeed the sparse field is gone, so we can close this.

Thanks for being aware of it.

Copy link
Contributor

@simahawk simahawk Aug 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome :)
I'll comment on the v14 PR for the other detail.


(...)
[queue_job]
Expand Down
2 changes: 1 addition & 1 deletion queue_job/__manifest__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"website": "https://github.com/OCA/queue",
"license": "LGPL-3",
"category": "Generic Modules",
"depends": ["mail"],
"depends": ["mail", "base_sparse_field"],
"external_dependencies": {"python": ["requests"]},
"data": [
"security/security.xml",
Expand Down
2 changes: 1 addition & 1 deletion queue_job/readme/CONFIGURE.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
[options]
(...)
workers = 6
server_wide_modules = web,queue_job
server_wide_modules = web,queue_job,base_sparse_field

(...)
[queue_job]
Expand Down
4 changes: 2 additions & 2 deletions queue_job/static/description/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
<meta name="generator" content="Docutils 0.15.1: http://docutils.sourceforge.net/" />
<meta name="generator" content="Docutils: http://docutils.sourceforge.net/" />
<title>Job Queue</title>
<style type="text/css">

Expand Down Expand Up @@ -454,7 +454,7 @@ <h1><a class="toc-backref" href="#id4">Configuration</a></h1>
<span class="k">[options]</span>
<span class="na">(...)</span>
<span class="na">workers</span> <span class="o">=</span> <span class="s">6</span>
<span class="na">server_wide_modules</span> <span class="o">=</span> <span class="s">web,queue_job</span>
<span class="na">server_wide_modules</span> <span class="o">=</span> <span class="s">web,queue_job,base_sparse_field</span>

<span class="na">(...)</span>
<span class="k">[queue_job]</span>
Expand Down