Use Workspace Dependencies#91
Merged
muraca merged 4 commits intoOff-Narrative-Labs:mainfrom Sep 23, 2023
Merged
Conversation
Signed-off-by: muraca <mmuraca247@gmail.com>
Signed-off-by: muraca <mmuraca247@gmail.com>
Signed-off-by: muraca <mmuraca247@gmail.com>
JoshOrndorff
approved these changes
Sep 23, 2023
Contributor
JoshOrndorff
left a comment
JoshOrndorff
left a comment
There was a problem hiding this comment.
Looks good to me assuming ci passes
Cargo.toml
Outdated
Comment on lines
+40
to
+43
| # wallet-only dependencies | ||
| serde_json = "1.0" | ||
| tokio = "1.25.0" | ||
| anyhow = "1.0.69" |
Contributor
There was a problem hiding this comment.
I like this separation of the dependencies in many ways. I also like having them alphabetical so that we can easily have a CI keep it in order.
For now let's leave it as it is except capitalize each line like this
Suggested change
| # wallet-only dependencies | |
| serde_json = "1.0" | |
| tokio = "1.25.0" | |
| anyhow = "1.0.69" | |
| # Wallet-only dependencies | |
| serde_json = "1.0" | |
| tokio = "1.25.0" | |
| anyhow = "1.0.69" |
I remember when I was at moonbeam, they wrote a tool called toml sort https://github.com/moonsong-labs/toml_sort for this exact purpose. I've opened follow-up issue #92 to use that in Tuxedo too.
@nanocryk are you guys still using / supporting toml-sort? I see no recent commits, but I guess that's just because it is simple and stable, right?
Signed-off-by: muraca <mmuraca247@gmail.com>
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #85