Conversation
Signed-off-by: muraca <mmuraca247@gmail.com>
Signed-off-by: muraca <mmuraca247@gmail.com>
Signed-off-by: muraca <mmuraca247@gmail.com>
JoshOrndorff
approved these changes
Oct 3, 2023
Collaborator
JoshOrndorff
left a comment
JoshOrndorff
left a comment
There was a problem hiding this comment.
Looks great. Left a few little thoughts. Overall I'm happy with it and excited to use it in Tuxedo and hopefully see it spread through the ecosystem.
CC @crystalin, @nanocryk, @ moonbeam team.
We are forking your toml-sort crate and turning it into a github action. We'd love to work together on this if you want to. But our PR and mention haven't gotten answered yet.
No problem if you don't have bandwidth to support an action. Just wanted to let you know our plans
Signed-off-by: muraca <mmuraca247@gmail.com>
Signed-off-by: muraca <mmuraca247@gmail.com>
Signed-off-by: muraca <mmuraca247@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like everything is working as expected, it takes a little bit since it needs to compile the tool every time.
Next steps:
we should definitely upload an artifact to be used instead of building every timedone, and it takes like 5 seconds to perform the checkout, download, extract and run;