WIP: enable cuda processing in PySyft#2690
Closed
midokura-silvia wants to merge 3 commits intomasterfrom
Closed
Conversation
LaRiffle
reviewed
Nov 8, 2019
syft/frameworks/torch/hook/hook.py
Outdated
| "__ge__", | ||
| "__lt__", | ||
| "__le__", | ||
| "data", |
Contributor
There was a problem hiding this comment.
I don't think you have to do this, you're already directly redefining torch.nn.Parameter.data
midokura-silvia
force-pushed
the
cuda
branch
from
5626e59 to
f627777
Compare
Contributor
Author
|
Closing PR as it tries to merge to master (and not dev) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unhooking the tensor.data attributes enables .to(device) to work correctly.
However, this seems to create some problems.
Thus, this pull request needs some more work to make the unit tests pass again. Any help would be greatly appreciated.