Conversation
LaRiffle
reviewed
Nov 15, 2019
Contributor
LaRiffle
left a comment
LaRiffle
left a comment
There was a problem hiding this comment.
Do you know if we could add cuda on travis?
I feel uncomfortable that the cuda test are not run in our CI:
test/torch/hook/test_hook.py::test_to SKIPPED [ 42%]
test/torch/hook/test_hook.py::test_cuda SKIPPED [ 42%]
test/torch/hook/test_hook.py::test_data SKIPPED [ 43%]
test/torch/hook/test_hook.py::test_param_data SKIPPED
Member
|
This is indeed possible - but I wouldn't want to require this to run PySyft's tests by default. https://stackoverflow.com/questions/3087361/gpu-emulator-for-cuda-programming-without-the-hardware |
iamtrask
approved these changes
Nov 17, 2019
Contributor
|
I know from a PyTorch contributor it is possible to test in GPU with CircleCI, but we would need a special plan for it. |
midokura-silvia
added a commit
to midokura-silvia/PySyft
that referenced
this pull request
Dec 4, 2019
* exclude tensor.data from hook to enable cuda processing * test cuda usage in pysyft * Directly call native_data (different from native_param_data) * Update of black version * Skip test if cuda is not available * Exclude functions marked pytest.mark.skipif from coverage
cereallarceny
pushed a commit
that referenced
this pull request
Dec 4, 2019
* exclude tensor.data from hook to enable cuda processing * test cuda usage in pysyft * Directly call native_data (different from native_param_data) * Update of black version * Skip test if cuda is not available * Exclude functions marked pytest.mark.skipif from coverage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
continued from #2690
Note that Travis is not testing the cuda part as cuda is (currently) not available.