Add initial version of compatiblity scenario text objects#350
Merged
Gymnasiast merged 8 commits intomasterfrom Oct 30, 2024
Merged
Add initial version of compatiblity scenario text objects#350Gymnasiast merged 8 commits intomasterfrom
Gymnasiast merged 8 commits intomasterfrom
Conversation
3 tasks
tupaschoal
reviewed
Oct 28, 2024
Member
tupaschoal
left a comment
tupaschoal
left a comment
There was a problem hiding this comment.
I love this idea of finally getting rid of that weird piece of text on the strings file.
Not sure how we can help to review, it's certainly too much to manually review. I don't love the indentation used, but then the automatic JSON formatters are usually pretty bad, so no big deal.
Member
|
ZehMatt has written one specifically for this repo. I can run it on the files once they have been generated. |
Gymnasiast
reviewed
Oct 30, 2024
objects/official/scenario_text/official.scenario_text.beneath_the_christmas_tree.json
Outdated
Show resolved
Hide resolved
Gymnasiast
reviewed
Oct 30, 2024
objects/official/scenario_text/official.scenario_text.beneath_the_christmas_tree.json
Outdated
Show resolved
Hide resolved
Gymnasiast
reviewed
Oct 30, 2024
objects/rct2/scenario_text/rct2.scenario_text.alpine_adventures.json
Outdated
Show resolved
Hide resolved
Gymnasiast
force-pushed
the
scenario_texts
branch
from
1041828 to
bc00756
Compare
Member
|
Note to self:
|
AaronVanGeffen
force-pushed
the
scenario_texts
branch
from
bc00756 to
cfd99bb
Compare
Gymnasiast
reviewed
Oct 30, 2024
objects/official/scenario_text/uces.scenario_text.beneath_the_christmas_tree.json
Outdated
Show resolved
Hide resolved
Gymnasiast
reviewed
Oct 30, 2024
objects/rct2ww/scenario_text/rct2ww.scenario_text.ayers_adventure.json
Outdated
Show resolved
Hide resolved
Gymnasiast
approved these changes
Oct 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dumped using a script: readParkStrings.py