Use local main.tf by default #59
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshmarsh
reviewed
Jan 10, 2020
|
|
||
| args := argsFromOverrides(overrides) | ||
| s.Util.Terraformer.Apply(args) | ||
| s.Util.Terraformer.Apply(ctx, []string{}) |
Contributor
There was a problem hiding this comment.
Maybe we should remove or change the above log statement. The output makes it look like it was already applied before asking if you want to apply dce resources
~ ./dce-cli system deploy
Creating DCE infrastructure
Initializing terraform working directory
Applying DCE infrastructure
Are you sure you would like to create DCE resources?
Contributor
Author
There was a problem hiding this comment.
Nice catch. I'll clean these up to show a better flow.
Contributor
Author
There was a problem hiding this comment.
Updated in latest push. The output now looks like this:
Initializing
Creating DCE infrastructure
Are you sure you would like to create DCE resources? (must type "yes" if yes) yes
Retrieving artifacts location
Artifacts bucket = 574035908831-dce-artifacts-dce-bmddqqcb
Deploying code assets to DCE infrastructure
Downloading DCE code assets
.
.
.
.
.
.
.
.
.
.
.
Updating AWS Lambda functions...
Finished updating AWS Lambda functions.…cal-state-by-default
Contributor
|
@nathanagood -- do you think we could do an in person review of this PR, given its size? |
Contributor
Author
@eschwartz - If by "in-person" you mean over vid, sure. I'd hate to wait until we are physically in-person. |
… logic reversed after code change.
nathanagood
commented
Jan 10, 2020
eschwartz
reviewed
Jan 10, 2020
eschwartz
reviewed
Jan 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Changes to resolve the following issues:
terraformbinary now and redirecting the output to a log file.system deploylogs are super verbose #41 - system deploy logs are now conciseTypes of changes
Checklist
README.md, inline comments, etc.)CHANGELOG.mdunder a## nextrelease, with a short summary of my changesRelevant Links
Further comments