Skip to content

Conversation

@joshmarsh
Copy link
Contributor

@joshmarsh joshmarsh commented Jan 10, 2020

Proposed changes

  • Moved quick start to readthedocs
  • Download deployment assets from the public url rather than using Github's GraphQL API

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (changes to code, which do not change application behavior)

Checklist

  • I have filled out this PR template
  • I have read the CONTRIBUTING doc
  • I have added automated tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (README.md, inline comments, etc.)
  • I have updated the CHANGELOG.md under a ## next release, with a short summary of my changes

Relevant Links

Further comments

@joshmarsh joshmarsh changed the title Updated CHANGELOG.md Release v3.0.1 Jan 10, 2020
@eschwartz
Copy link
Contributor

@joshmarsh -- you mentioned offline that this would resolve Optum/dce#209

Can you provide more details? What's the deal with those s3 policies, and how does this release fix it?

@joshmarsh
Copy link
Contributor Author

Good clarifying question, and it looks like there may actually be a deeper issue here.

This release solves the issue of the Github v4 API requiring a personal access token to download deployment artifacts, and I suspect that’s what caused the failure that lead to Optum/dce#209 being noticed.

I don’t have an answer right now, so let’s mark this as a bug and revisit it after #59 is merged. As a cursory observation, I don’t see the MalformedPolicy error present in the deployment logs from #59.

@joshmarsh joshmarsh merged commit dde7480 into Optum:master Jan 10, 2020
@joshmarsh joshmarsh deleted the release/v3.0.1 branch January 10, 2020 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants