Skip to content

[Oztechan/CCC#3888] Remove onBaseChange event#3889

Merged
mustafaozhan merged 2 commits intodevelopfrom
3888-Remove-onBaseChange-event-from-CalculatorView
Sep 9, 2024
Merged

[Oztechan/CCC#3888] Remove onBaseChange event#3889
mustafaozhan merged 2 commits intodevelopfrom
3888-Remove-onBaseChange-event-from-CalculatorView

Conversation

@mustafaozhan
Copy link
Member

Resolves #3888

@mustafaozhan mustafaozhan requested a review from a team as a code owner September 9, 2024 09:02
@codacy-production
Copy link

codacy-production bot commented Sep 9, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.04%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (06e1de4) 3226 1727 53.53%
Head commit (f92e682) 3223 (-3) 1724 (-3) 53.49% (-0.04%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#3889) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@codecov
Copy link

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.13%. Comparing base (06e1de4) to head (f92e682).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3889      +/-   ##
===========================================
- Coverage    57.18%   57.13%   -0.04%     
===========================================
  Files          166      166              
  Lines         2905     2902       -3     
  Branches       435      435              
===========================================
- Hits          1661     1658       -3     
  Misses        1220     1220              
  Partials        24       24              

Impacted file tree graph

Files with missing lines Coverage Δ
.../ccc/client/viewmodel/calculator/CalculatorSEED.kt 100.00% <ø> (ø)
...client/viewmodel/calculator/CalculatorViewModel.kt 99.32% <ø> (-0.01%) ⬇️

@mustafaozhan mustafaozhan changed the title [Oztechan/CCC#3888] Remove onBaseChange event from CalculatorView [Oztechan/CCC#3888] Remove onBaseChange event Sep 9, 2024
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 9, 2024

@mustafaozhan mustafaozhan merged commit d88982b into develop Sep 9, 2024
@mustafaozhan mustafaozhan deleted the 3888-Remove-onBaseChange-event-from-CalculatorView branch September 9, 2024 20:30
mustafaozhan added a commit that referenced this pull request Sep 10, 2024
* [#3880] Cover onSheetDismissed Event for CalculatorViewModel (#3881)

* [#3884] Set base currency when SelectCurrencySheet item is clicked (#3885)

* [#3884] Set base currency when SelectCurrencySheet item is clicked

* [#3884] Set base currency when SelectCurrencySheet item is clicked

* [#3888] Remove onBaseChange event (#3889)

* [#3888] Remove onBaseChange event from CalculatorView

* [#3888] Remove onBaseChange event

* [#1457] Update Git Submodules

Co-authored-by: Mustafa Ozhan <mr.mustafa.ozhan@gmail.com>

---------

Co-authored-by: Mustafa Ozhan <mr.mustafa.ozhan@gmail.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
mustafaozhan added a commit that referenced this pull request Sep 10, 2024
* [#3880] Cover onSheetDismissed Event for CalculatorViewModel (#3881)

* [#3884] Set base currency when SelectCurrencySheet item is clicked (#3885)

* [#3884] Set base currency when SelectCurrencySheet item is clicked

* [#3884] Set base currency when SelectCurrencySheet item is clicked

* [#3888] Remove onBaseChange event (#3889)

* [#3888] Remove onBaseChange event from CalculatorView

* [#3888] Remove onBaseChange event

* [#1457] Update Git Submodules

Co-authored-by: Mustafa Ozhan <mr.mustafa.ozhan@gmail.com>

---------

Co-authored-by: Mustafa Ozhan <mr.mustafa.ozhan@gmail.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
mustafaozhan added a commit that referenced this pull request Sep 10, 2024
* [#1457] Update dependency gradle to v8.10.1

Co-authored-by: Mustafa Ozhan <mr.mustafa.ozhan@gmail.com>

* [#1457] Update Git Submodules (#3890)

* [#3880] Cover onSheetDismissed Event for CalculatorViewModel (#3881)

* [#3884] Set base currency when SelectCurrencySheet item is clicked (#3885)

* [#3884] Set base currency when SelectCurrencySheet item is clicked

* [#3884] Set base currency when SelectCurrencySheet item is clicked

* [#3888] Remove onBaseChange event (#3889)

* [#3888] Remove onBaseChange event from CalculatorView

* [#3888] Remove onBaseChange event

* [#1457] Update Git Submodules

Co-authored-by: Mustafa Ozhan <mr.mustafa.ozhan@gmail.com>

---------

Co-authored-by: Mustafa Ozhan <mr.mustafa.ozhan@gmail.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Mustafa Ozhan <mr.mustafa.ozhan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove onBaseChange event

1 participant