Skip to content

Comments

[Oztechan/CCC#1457] Update Git Submodules#3890

Merged
mustafaozhan merged 4 commits intorenovate/gradle-8.xfrom
renovate/git-submodules
Sep 10, 2024
Merged

[Oztechan/CCC#1457] Update Git Submodules#3890
mustafaozhan merged 4 commits intorenovate/gradle-8.xfrom
renovate/git-submodules

Conversation

@renovate
Copy link
Contributor

@renovate renovate bot commented Sep 10, 2024

This PR contains the following updates:

Package Update Change
submodule/basemob digest d599c74 -> 5aed284
submodule/logmob digest 188a7cc -> f46f3ad
submodule/parsermob digest e83695c -> fe5ab5d
submodule/scopemob digest 80464f8 -> b477631

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

mustafaozhan and others added 4 commits September 9, 2024 11:53
…3885)

* [#3884] Set base currency when SelectCurrencySheet item is clicked

* [#3884] Set base currency when SelectCurrencySheet item is clicked
* [#3888] Remove onBaseChange event from CalculatorView

* [#3888] Remove onBaseChange event
Co-authored-by: Mustafa Ozhan <mr.mustafa.ozhan@gmail.com>
@renovate renovate bot requested a review from mustafaozhan as a code owner September 10, 2024 08:10
@renovate renovate bot added the dependencies Pull requests that update a dependency file label Sep 10, 2024
@renovate renovate bot requested a review from a team as a code owner September 10, 2024 08:10
@codacy-production
Copy link

codacy-production bot commented Sep 10, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.20% 66.67%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (bd8ac99) 3224 1718 53.29%
Head commit (3436740) 3223 (-1) 1724 (+6) 53.49% (+0.20%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#3890) 3 2 66.67%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@codecov
Copy link

codecov bot commented Sep 10, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 57.13%. Comparing base (bd8ac99) to head (3436740).
Report is 5 commits behind head on renovate/gradle-8.x.

Files with missing lines Patch % Lines
...currency/di/ClientViewModelSelectCurrencyModule.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                   Coverage Diff                   @@
##           renovate/gradle-8.x    #3890      +/-   ##
=======================================================
+ Coverage                56.94%   57.13%   +0.19%     
=======================================================
  Files                      166      166              
  Lines                     2903     2902       -1     
  Branches                   435      435              
=======================================================
+ Hits                      1653     1658       +5     
+ Misses                    1226     1220       -6     
  Partials                    24       24              

Impacted file tree graph

Files with missing lines Coverage Δ
.../ccc/client/viewmodel/calculator/CalculatorSEED.kt 100.00% <ø> (ø)
...client/viewmodel/calculator/CalculatorViewModel.kt 99.32% <ø> (+4.01%) ⬆️
...iewmodel/selectcurrency/SelectCurrencyViewModel.kt 100.00% <100.00%> (ø)
...currency/di/ClientViewModelSelectCurrencyModule.kt 0.00% <0.00%> (ø)

@sonarqubecloud
Copy link

@mustafaozhan mustafaozhan changed the base branch from develop to renovate/gradle-8.x September 10, 2024 10:51
@mustafaozhan mustafaozhan merged commit 2a78f6d into renovate/gradle-8.x Sep 10, 2024
@mustafaozhan mustafaozhan deleted the renovate/git-submodules branch September 10, 2024 10:51
mustafaozhan added a commit that referenced this pull request Sep 10, 2024
* [#3880] Cover onSheetDismissed Event for CalculatorViewModel (#3881)

* [#3884] Set base currency when SelectCurrencySheet item is clicked (#3885)

* [#3884] Set base currency when SelectCurrencySheet item is clicked

* [#3884] Set base currency when SelectCurrencySheet item is clicked

* [#3888] Remove onBaseChange event (#3889)

* [#3888] Remove onBaseChange event from CalculatorView

* [#3888] Remove onBaseChange event

* [#1457] Update Git Submodules

Co-authored-by: Mustafa Ozhan <mr.mustafa.ozhan@gmail.com>

---------

Co-authored-by: Mustafa Ozhan <mr.mustafa.ozhan@gmail.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
mustafaozhan added a commit that referenced this pull request Sep 10, 2024
* [#1457] Update dependency gradle to v8.10.1

Co-authored-by: Mustafa Ozhan <mr.mustafa.ozhan@gmail.com>

* [#1457] Update Git Submodules (#3890)

* [#3880] Cover onSheetDismissed Event for CalculatorViewModel (#3881)

* [#3884] Set base currency when SelectCurrencySheet item is clicked (#3885)

* [#3884] Set base currency when SelectCurrencySheet item is clicked

* [#3884] Set base currency when SelectCurrencySheet item is clicked

* [#3888] Remove onBaseChange event (#3889)

* [#3888] Remove onBaseChange event from CalculatorView

* [#3888] Remove onBaseChange event

* [#1457] Update Git Submodules

Co-authored-by: Mustafa Ozhan <mr.mustafa.ozhan@gmail.com>

---------

Co-authored-by: Mustafa Ozhan <mr.mustafa.ozhan@gmail.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Mustafa Ozhan <mr.mustafa.ozhan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant