[series/9.x] add shard preference support for update by query async requests#3889
Open
flavienbert wants to merge 2 commits intoPhilippus:series/9.xfrom
Open
[series/9.x] add shard preference support for update by query async requests#3889flavienbert wants to merge 2 commits intoPhilippus:series/9.xfrom
flavienbert wants to merge 2 commits intoPhilippus:series/9.xfrom
Conversation
Owner
|
As far as I can tell, shard preference isn't the only preference option available for that call. I'd prefer to model it the same as we do with GetRequest, as in: |
f069690 to
2f9808d
Compare
Contributor
Author
|
The modification is done. It doesn’t enforce that at least one shard is provided or same shards are provided, and shards are defined as String instead of Int. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for the
preference=_shards:0,1,2,3parameter in async update-by-query operations through a new ShardsPreferenceRequest case class.Changes:
shards: Option[ShardsPreferenceRequest]field to UpdateByQueryAsyncRequest