Skip to content

Add registration page to available links#156

Merged
kpodemski merged 1 commit intoPrestaShop:devfrom
Hlavtox:registration
Dec 14, 2022
Merged

Add registration page to available links#156
kpodemski merged 1 commit intoPrestaShop:devfrom
Hlavtox:registration

Conversation

@Hlavtox
Copy link
Contributor

@Hlavtox Hlavtox commented Oct 21, 2022

Questions Answers
Description? Adds new registration page to available links.
Type? bug fix
BC breaks? no
Deprecations? no
Fixed ticket? Fixes PrestaShop/PrestaShop#27755
How to test? Try to edit link block and see that you can now add registration page.

cc @Caleydon

kpodemski
kpodemski previously approved these changes Nov 8, 2022
@kpodemski kpodemski added this to the 5.0.6 milestone Nov 8, 2022
@sallemiines
Copy link

sallemiines commented Nov 14, 2022

Hello @Hlavtox,

Thanks for the PR !

Following the existing steps in the Readme-file of the module, I tried to check the pr :

After cloning the module from github > cd modules /ps_linklist /views : type npm run OK , you can see the attached screenshot
image

but when I type this line command npm run build , i get this error , you can see the attached screenshots

image

image

image

Unfortunately i cannot install the module to continue the tests !
Did I miss something ?

PS : node version used is : v14.19.3 && npm version 7.24.2

Please check and feedback ! 🙏

Thank you

@sallemiines sallemiines added Waiting for author Waiting for author feedback and removed Waiting for QA labels Nov 14, 2022
@sallemiines sallemiines removed their assignment Nov 14, 2022
@Hlavtox
Copy link
Contributor Author

Hlavtox commented Nov 14, 2022

@sallemiines I don't know, but I think that my change doesn't cause your issues. 👍
Ping @kpodemski

@NeOMakinG
Copy link

@sallemiines should be fixed by #160

NeOMakinG
NeOMakinG previously approved these changes Nov 17, 2022
@NeOMakinG NeOMakinG removed the Waiting for author Waiting for author feedback label Nov 17, 2022
@NeOMakinG NeOMakinG requested a review from kpodemski November 17, 2022 14:39
@NeOMakinG
Copy link

@kpodemski I did fix the build and rebased, if you can reapprove and send to QA, would be cool 😗

kpodemski
kpodemski previously approved these changes Nov 17, 2022
@sallemiines
Copy link

Hello @Hlavtox

I have checked your PR. But, it seems that the issue is not fixed. I did not find the registration page when edit a block of linklist
here a screen-record for it :

My.items.-.Awesome.Screenshot.mp4

Could you please check it ?

@sallemiines sallemiines added the Waiting for author Waiting for author feedback label Nov 18, 2022
@Hlavtox Hlavtox dismissed stale reviews from kpodemski and NeOMakinG via 31b2a86 November 18, 2022 15:45
@Hlavtox
Copy link
Contributor Author

Hlavtox commented Nov 18, 2022

Hi @sallemiines, I checked and found why you could not see it. A friendly URL is not yet added for this new registration page on install. I fixed it for 8.0.x branch here - PrestaShop/PrestaShop#30093, but it will be backported to develop later.

So to test it on develop, go to SEO & URLs page in backoffice and add registration manually:
registration

Then you will see the new page in linklist module:
registra

@Hlavtox Hlavtox added Waiting for QA and removed Waiting for author Waiting for author feedback labels Dec 13, 2022
@Hlavtox
Copy link
Contributor Author

Hlavtox commented Dec 13, 2022

@khouloudbelguith @sallemiines Can you recheck or what is the status of this PR? Thanks!

@florine2623 florine2623 self-assigned this Dec 14, 2022
Copy link
Contributor

@florine2623 florine2623 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @Hlavtox ,

Tested on 8.0.x, it is ✅

BO FO
Screenshot 2022-12-14 at 17 26 56 Screenshot 2022-12-14 at 17 39 05

Tested on 1.7.8.x, it is KO ❌

BO FO
Screenshot 2022-12-14 at 17 27 59 Screenshot 2022-12-14 at 17 28 03

Is there a special manipulation to make it display on 1.7.8.x ?
Waiting for your feedback, thanks!

@florine2623 florine2623 added Waiting for author Waiting for author feedback and removed Waiting for QA labels Dec 14, 2022
@florine2623 florine2623 removed their assignment Dec 14, 2022
@Hlavtox
Copy link
Contributor Author

Hlavtox commented Dec 14, 2022

@florine2623 The page did not exist before v8, so its Ok :)

@Hlavtox Hlavtox added QA ✔️ Status: Check done, Code approved and removed Waiting for author Waiting for author feedback labels Dec 14, 2022
@kpodemski kpodemski merged commit 9d5847a into PrestaShop:dev Dec 14, 2022
@Hlavtox Hlavtox deleted the registration branch December 14, 2022 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

QA ✔️ Status: Check done, Code approved

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants