Add registration page to available links#156
Conversation
|
Hello @Hlavtox, Thanks for the PR ! Following the existing steps in the Readme-file of the module, I tried to check the pr : After cloning the module from github > cd modules /ps_linklist /views : type but when I type this line command Unfortunately i cannot install the module to continue the tests ! PS : node version used is : v14.19.3 && npm version 7.24.2 Please check and feedback ! 🙏 Thank you |
|
@sallemiines I don't know, but I think that my change doesn't cause your issues. 👍 |
|
@sallemiines should be fixed by #160 |
31b2a86 to
0c1337a
Compare
|
@kpodemski I did fix the build and rebased, if you can reapprove and send to QA, would be cool 😗 |
|
Hello @Hlavtox I have checked your PR. But, it seems that the issue is not fixed. I did not find the registration page when edit a block of linklist My.items.-.Awesome.Screenshot.mp4Could you please check it ? |
bced972 to
31b2a86
Compare
31b2a86 to
9484277
Compare
|
Hi @sallemiines, I checked and found why you could not see it. A friendly URL is not yet added for this new So to test it on develop, go to |
|
@khouloudbelguith @sallemiines Can you recheck or what is the status of this PR? Thanks! |
florine2623
left a comment
There was a problem hiding this comment.
Hello @Hlavtox ,
Tested on 8.0.x, it is ✅
| BO | FO |
|---|---|
![]() |
![]() |
Tested on 1.7.8.x, it is KO ❌
| BO | FO |
|---|---|
![]() |
![]() |
Is there a special manipulation to make it display on 1.7.8.x ?
Waiting for your feedback, thanks!
|
@florine2623 The page did not exist before v8, so its Ok :) |










cc @Caleydon