Configure typescript properly to fix the build#160
Merged
NeOMakinG merged 1 commit intoPrestaShop:devfrom Nov 17, 2022
Merged
Conversation
mflasquin
approved these changes
Nov 16, 2022
kpodemski
approved these changes
Nov 16, 2022
MhiriFaten
reviewed
Nov 16, 2022
MhiriFaten
left a comment
MhiriFaten
left a comment
There was a problem hiding this comment.
Hello @NeOMakinG ,
I still find the issue and I'm still investigating.
Also, there are some checks were not successful
Could you check please?
Thank you.
MhiriFaten
added
Waiting for author
Author
It's not related to that PR at all |
NeOMakinG
added
Waiting for QA
and removed
Waiting for author
MhiriFaten
approved these changes
Nov 17, 2022
MhiriFaten
added
QA ✔️
Author
|
Thanks @MhiriFaten |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npm i && npm run buildinsideviews