Add query to NGC to get matched model URL and version.

[IsaacYangSLA]

Allow mmar download with latest version or a specific version.

Signed-off-by: Isaac Yang isaacy@nvidia.com

Fixes #2365 .

Description

Add api, version options to current download_mmar method to enable query NGC for list of models, and the version to download.

Status

Ready

Types of changes

• Non-breaking change (fix or new feature that would not break existing functionality).
• Breaking change (fix or new feature that would cause existing functionality to change).
• New tests added to cover the changes.
• Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
• Quick tests passed locally by running ./runtests.sh --quick --unittests.
• In-line docstrings updated.
• Documentation updated, tested make html command in the docs/ folder.

[Nic-Ma]

/integration-test

[wyli]

thanks!

[Nic-Ma]

Thanks for fixing /integration-test in this PR.

[wyli]

Thanks for fixing /integration-test in this PR.

what was the issue in the integration test?

[Nic-Ma]

Thanks for fixing /integration-test in this PR.

what was the issue in the integration test?

Hi @wyli ,

I found the /integration-test command actually didn't trigger the CI tests in PRs last night.
As you can see, @IsaacYangSLA added requests to requirements-dev.txt in this PR to fix it.

Thanks.

[wyli]

Thanks for fixing /integration-test in this PR.

what was the issue in the integration test?

Hi @wyli ,

I found the /integration-test command actually didn't trigger the CI tests in PRs last night.
As you can see, @IsaacYangSLA added requests to requirements-dev.txt in this PR to fix it.

Thanks.

I don't think requests is explicitly used in the current dev branch, and requests is a part of the pytorch requirements https://github.com/pytorch/pytorch/blob/master/requirements.txt#L7 is probably installed anyway... if there are integration test errors, this couldn't be the fix

[Nic-Ma]

/integration-test

[Nic-Ma]

Hi @wyli , thanks for your helpful analysis and suggestion! @IsaacYangSLA what do you think about this command issue?

[Nic-Ma]

Hi @wyli, BTW, I found the GPU tests of CI are very slow today, do you think it's something related to Blossom env or our config error?

Thanks in advance.

[wyli]

as far as I can see it's not a blossom/config issue

[IsaacYangSLA]

Thanks for fixing /integration-test in this PR.

what was the issue in the integration test?

Hi @wyli ,
I found the /integration-test command actually didn't trigger the CI tests in PRs last night.
As you can see, @IsaacYangSLA added requests to requirements-dev.txt in this PR to fix it.
Thanks.

I don't think requests is explicitly used in the current dev branch, and requests is a part of the pytorch requirements https://github.com/pytorch/pytorch/blob/master/requirements.txt#L7 is probably installed anyway... if there are integration test errors, this couldn't be the fix

Hi @wyli, I did a wheel install of torch (1.8 and 1.9) in a fresh virtual env and found none of them installed requests automatically. Maybe its setup.py does not load requirements.txt.