Fixed an error in DiNTS model implementation and enabled act and norm layer options #4157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: dongy <[email protected]>
Signed-off-by: dongy <[email protected]>
Contributor
|
/build |
Contributor
yiheng-wang-nv
left a comment
yiheng-wang-nv
left a comment
There was a problem hiding this comment.
Hi @dongyang0122 , it looks good to me, could you please also add the unit tests for act and norm? Thanks!
Signed-off-by: dongy <[email protected]>
Collaborator
Author
|
@yiheng-wang-nv thanks for the comments! test cases are updated. |
yiheng-wang-nv
approved these changes
Apr 23, 2022
Contributor
|
/build |
Contributor
|
/build |
2 similar comments
Contributor
|
/build |
Contributor
|
/build |
Contributor
|
/build |
wyli
added a commit
that referenced
this pull request
Apr 26, 2022
* 4095 Add bundle download (#4114) * draft download Signed-off-by: Yiheng Wang <[email protected]> * update bundle download Signed-off-by: Yiheng Wang <[email protected]> * add url and load Signed-off-by: Yiheng Wang <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * rename args and remove a few places Signed-off-by: Yiheng Wang <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix flake8 issue Signed-off-by: Yiheng Wang <[email protected]> * enhance with reviews Signed-off-by: Yiheng Wang <[email protected]> * add instantiate for load Signed-off-by: Yiheng Wang <[email protected]> * fix black error Signed-off-by: Yiheng Wang <[email protected]> * add unittest Signed-off-by: Yiheng Wang <[email protected]> * add load to docs Signed-off-by: Yiheng Wang <[email protected]> * add skip Signed-off-by: Yiheng Wang <[email protected]> * add schemaerror Signed-off-by: Yiheng Wang <[email protected]> * fix partial places Signed-off-by: Yiheng Wang <[email protected]> * download zip bundle Signed-off-by: Yiheng Wang <[email protected]> * [DLMED] restore Exception for test Signed-off-by: Nic Ma <[email protected]> * update ts features Signed-off-by: Yiheng Wang <[email protected]> * add config_files test case Signed-off-by: Yiheng Wang <[email protected]> * enhance docstring example for args_file Signed-off-by: Yiheng Wang <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Nic Ma <[email protected]> * Disable pylint error and fix CI tests of new tifffile (#4162) * workaround Signed-off-by: Nic Ma <[email protected]> * [DLMED] fix tifffile issue Signed-off-by: Nic Ma <[email protected]> * Fixed an error in DiNTS model implementation and enabled act and norm layer options (#4157) * fixed a bug Signed-off-by: dongy <[email protected]> * autofix Signed-off-by: dongy <[email protected]> * update test case Signed-off-by: dongy <[email protected]> Co-authored-by: dongy <[email protected]> * Split transform (#4153) * Redesign whole slide image reading (#4107) * Redesign BaseWSIReader, WSIReader, CuCIMWSIReader Signed-off-by: Behrooz <[email protected]> * Add unittests for WSIReader Signed-off-by: Behrooz <[email protected]> * Add image mode for output validation Signed-off-by: Behrooz <[email protected]> * Update docs Signed-off-by: Behrooz <[email protected]> * Update references to new WSIReader Signed-off-by: Behrooz <[email protected]> * Remove legacy WSIReader Signed-off-by: Behrooz <[email protected]> * Update unittests Signed-off-by: Behrooz <[email protected]> * Update docs Signed-off-by: Behrooz <[email protected]> * sort imports Signed-off-by: Behrooz <[email protected]> * Clean up imports Signed-off-by: Behrooz <[email protected]> * Update docstrings Signed-off-by: Behrooz <[email protected]> * Update docs and docstrings Signed-off-by: Behrooz <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Fix a typo Signed-off-by: Behrooz <[email protected]> * Remove redundant checking Signed-off-by: Behrooz <[email protected]> * Update read and other methods Signed-off-by: Behrooz <[email protected]> * Update wsireader to support multi image and update docstrings Signed-off-by: Behrooz <[email protected]> * Make workaround for CuImage objects Signed-off-by: Behrooz <[email protected]> * Add unittests for multi image reading Signed-off-by: Behrooz <[email protected]> * Update a note about cucim Signed-off-by: Behrooz <[email protected]> * Update type hints and docstrings Signed-off-by: Behrooz <[email protected]> * Implement Split transform Signed-off-by: Behrooz <[email protected]> * Add unittests Signed-off-by: Behrooz <[email protected]> * Update formatting Signed-off-by: Behrooz <[email protected]> * Implement SplitDict Signed-off-by: Behrooz <[email protected]> * Add unittests for SplitDict Signed-off-by: Behrooz <[email protected]> * Add docs Signed-off-by: Behrooz <[email protected]> * Remove images from docs Signed-off-by: Behrooz <[email protected]> * Address all comments Signed-off-by: Behrooz <[email protected]> * Add example and size check Signed-off-by: Behrooz <[email protected]> * Update docs Signed-off-by: Behrooz <[email protected]> * Revert references to new wsireader Signed-off-by: Behrooz <[email protected]> * Add missing comma Signed-off-by: Behrooz <[email protected]> * fix bundle download test issue (#4169) Signed-off-by: Yiheng Wang <[email protected]> * 4094 Enhance `ckpt_export` to save config files (#4159) * [DLMED] enhance checkpoint export Signed-off-by: Nic Ma <[email protected]> * [DLMED] update according to comments Signed-off-by: Nic Ma <[email protected]> * Move RGB/RGBA checks to base class (#4171) Signed-off-by: Behrooz <[email protected]> Co-authored-by: Nic Ma <[email protected]> * [CICD] To support temp dgx runner (#4175) * Support new temp dgx runner Signed-off-by: Peixin Li <[email protected]> * atol 1e-5 Signed-off-by: Wenqi Li <[email protected]> Co-authored-by: Wenqi Li <[email protected]> * Test fix for AMP kwargs (#4178) Signed-off-by: Eric Kerfoot <[email protected]> Co-authored-by: Yiheng Wang <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Nic Ma <[email protected]> Co-authored-by: dongyang0122 <[email protected]> Co-authored-by: dongy <[email protected]> Co-authored-by: Behrooz <[email protected]> Co-authored-by: Peixin <[email protected]> Co-authored-by: Eric Kerfoot <[email protected]>
Can-Zhao
pushed a commit
to Can-Zhao/MONAI
that referenced
this pull request
May 10, 2022
… layer options (Project-MONAI#4157) * fixed a bug Signed-off-by: dongy <[email protected]> * autofix Signed-off-by: dongy <[email protected]> * update test case Signed-off-by: dongy <[email protected]> Co-authored-by: dongy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: dongy [email protected]
Fixes # .
Description
A few sentences describing the changes proposed in this pull request.Fixed an error in DiNTS model implementation and enabled act and norm layer options.
Status
Ready
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.