Golint vet errcheck on ProtonMail fork#32
Open
zugzwang wants to merge 15 commits intoProtonMail:mainfrom
Open
Conversation
Closed
Halfway through Halfway through Finished first pass Solving tests. Relaxing a bit on useless comments, but frowning. Fix comment Linted openpgp/packet, at least some of it Reverting ID -> Id Reverting Fingerprint -> FingerPrint Solving tests Relaxing on some useless comment and reverting Fingerprint -> FingerPrint Missing parenthesis Corrected exported object comments globally
zugzwang
force-pushed
the
golint-vet-errcheck-protonmail-fork
branch
from
66d0d73 to
12366c5
Compare
twiss
reviewed
Nov 1, 2019
Co-Authored-By: Daniel Huigens <d.huigens@protonmail.com>
…wang/crypto into golint-vet-errcheck-protonmail-fork
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch contains a better linted crypto package with golint, vet, errcheck, deadcode, etc.