Made it possible to have a value included in many group values#168
Merged
Made it possible to have a value included in many group values#168
Conversation
Collaborator
|
On the bug ( for when we revist this in the future :-) ): Our metadata editors have an instruction not to create groupings where 2 groups have the same child. |
Change from valueCode to parentCode as keys in dicts holding data from value group
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



There is a bug in the 2.4 version where you get an exception in
MetaQueryseePCAxis.Sql/PCAxis.Sql/QueryLib_24/MetaQuery.cs
Line 1279 in 157fb58
ValueCodethat is in many groups which should be ok.This PR checks change the dictionary to be a list of row instead of a single row and also checks if the key i already in the dictionary before trying to add it.