Merged
Conversation
armansito
approved these changes
Mar 16, 2025
Collaborator
armansito
left a comment
There was a problem hiding this comment.
Thank you for the kind words and corrections!
Collaborator
Thank you for the report. I ran into a different issue related to mouse handling that also got resolved with the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
Thanks for your amazing work on this book. I've just completed the last available chapter of the book, and it was a very fun experience.
I encountered two small typos and one missing import, which are fixed in this PR.
Another thing that I encountered was that
DeviceEvent::MouseWheelandDeviceEvent::Buttonwould not trigger on my PC, instead i've usedWindowEvent::MouseWheelandWindowEvent::MouseInputthat did trigger. My guess it has something to do with the environment i'm running the program in (swayon NixOS unstable). For reference here is my event loop run: