Skip to content

fix typo and import PI #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
armansito merged 1 commit into from
Mar 16, 2025
Merged

fix typo and import PI #22

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions book/RayTracingGPUEdition.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5316,6 +5316,14 @@
$-\frac{1}{2}\pi$:

~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Rust
use {
bytemuck::{Pod, Zeroable},
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Rust delete
std::f32::consts::FRAC_PI_2,
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Rust highlight
std::f32::consts::{FRAC_PI_2, PI},
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Rust
};
...
impl Camera {
...
Expand Down Expand Up @@ -5426,7 +5434,7 @@

The appearance of a real-world object depends on its material composition. This includes surface
features--like the overall smoothness of the surface--and molecular properties like electrical
conductivity and crystal structure. Generally we can get a way with an approximate representation
conductivity and crystal structure. Generally we can get away with an approximate representation
of what makes an object appear like a metal or glass, with parameters that an artist can tune
to achieve a particular appearance.

Expand Down Expand Up @@ -6269,7 +6277,7 @@

The issue with NaN/INF values is gone and we now see a mirror reflection where the blue ring used to be. The image is
still wrong though, as there is now a black circle in the middle again. In the black region, the camera ray refracts
into the sphere but the rest of the light transport path gets stuck in a total internal reflection loop. Tha path
into the sphere but the rest of the light transport path gets stuck in a total internal reflection loop. The path
tracing loop eventually exits without reaching the sky, hence the black.

### Fixing the refraction ratio
Expand Down