BREAKING(package): update SUI to 2.3 by layershifter · Pull Request #2657 · Semantic-Org/Semantic-UI-React

layershifter · 2018-03-18T09:57:42Z

BREAKING

This PR requieres usage of Semantic UI CSS >= 2.3.x

Fixes #2550. This PR should:

update Dimmer to be compatible with SUI 2.3 (feat(Dimmer): update SUI to 2.3, add verticalAlign #2656)
update Modal to be compatible with SUI 2.3 (breaking(Modal): Fix vertical position with SUI 2.3 #2690)
update Icon to use FA5 (feat(Icon): update SUI to 2.3 #2665)
add support for new Transition names: zoom and glow (feat(Transition): update SUI to 2.3, add zoom and glow #2658)

codecov-io · 2018-03-18T10:02:19Z

Codecov Report

Merging #2657 into master will decrease coverage by 0.07%.
The diff coverage is 94.28%.

@@            Coverage Diff             @@
##           master    #2657      +/-   ##
==========================================
- Coverage   99.74%   99.66%   -0.08%     
==========================================
  Files         160      161       +1     
  Lines        2696     2714      +18     
==========================================
+ Hits         2689     2705      +16     
- Misses          7        9       +2

Impacted Files	Coverage Δ
src/addons/Portal/Portal.js	`100% <100%> (ø)`	⬆️
src/modules/Dimmer/Dimmer.js	`100% <100%> (ø)`	⬆️
src/modules/Progress/Progress.js	`100% <100%> (ø)`	⬆️
src/modules/Modal/Modal.js	`100% <100%> (ø)`	⬆️
src/modules/Dimmer/DimmerInner.js	`90.47% <90.47%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b298d59...9ae4b76. Read the comment docs.

levithomason · 2018-03-18T16:25:23Z

We should update the install docs to note SUI >=2.3 is required.

ghost · 2018-03-20T19:19:46Z

There is a message for Modals in 2.3.1: https://github.com/Semantic-Org/Semantic-UI/blob/master/RELEASE-NOTES.md.

A Special Message about Flex Modals There will be an update shortly to resolve issues related to flex modals when using multiple modals and detachable: false, in order to not hold up this release, we've decided to move forward without a fix.

A general solution will most likely require branching code for IE11 which will disable flex (as IE11 doesnt correctly implement the latest spec for absolute positioned flex containers).

chuckhagy · 2018-03-23T17:22:21Z

This PR fixes an app I'm working on... can I get an ETA on when it's expected to be merged in?

* Update SUI css to 2.3.1 * Disable negative top margin calc * Add the ability to apply inline styles to Portal * Top Aligned modal example * Make sure we are not overriding the top margin inline * type defs updated for Portal * Type update for Modal * Refactor to use setProperty instead of string for important * Remove inline-style lib to handle string differently

layershifter · 2018-04-16T18:44:26Z

This PR requires some chore work before merge, I want to finish it on this weekend.

brianespinosa · 2018-04-16T20:01:02Z

It doesn't look like there is a change made to the README.md file to remove the warning at the very top about incompatibility with SUI =< 2.3. We should probably remove that.

We should update the install docs to note SUI >=2.3 is required.

We should definitely have something prominently displayed still regarding the above note.

…React into next # Conflicts: # docs/app/Views/Theming.js # yarn.lock

layershifter · 2018-04-30T09:53:29Z

Changes that were made unded Semantic-Org/Semantic-UI#6226 made icon generator useless.

I'll manually generate icons and add notice about versions.

layershifter · 2018-04-30T12:00:12Z

README.md

@@ -1,5 +1,3 @@
-⚠️NOTE: Currently Semantic UI React is not yet compatible with the latest 2.3 version of Semantic UI styles. See [#2250](https://github.com/Semantic-Org/Semantic-UI-React/issues/2550) for more info.
-


Now we can remove this note 👍

layershifter · 2018-04-30T12:01:27Z

docs/app/Views/Usage.js

+          <Message.Item>for SUI 2.2 use 0.79.1 and below</Message.Item>
+          <Message.Item>for SUI 2.3 use 0.80.0 and higher</Message.Item>
+        </Message.List>
+      </Message>


Notice about version support

layershifter · 2018-04-30T12:04:54Z

Marked as ready for review 👍

…React into next

levithomason · 2018-05-06T15:57:33Z

Hope to add my review by EOD Monday.

aminland · 2018-05-22T19:42:07Z

Is there an ETA on when this might be merged?

…React into next # Conflicts: # src/index.js

layershifter · 2018-05-25T06:09:02Z

I merged this branch with master, waiting for @levithomason

levithomason · 2018-05-31T23:24:30Z

I've merged master, fixed conflicts, and fixed the icon search. This is good to go once tests pass.

levithomason · 2018-06-03T03:15:19Z

Released in semantic-ui-react@0.81.0.

layershifter added 2 commits March 18, 2018 10:38

chore(package): update SUI to 2.3

153700f

feat(Dimmer): update SUI to 2.3, add verticalAlign (#2656)

eaab06c

layershifter added the enhancement label Mar 18, 2018

feat(Transition): update SUI to 2.3, add zoom and glow (#2658)

935d0ff

layershifter mentioned this pull request Mar 18, 2018

Update SUIR to be compatible with SUI 2.3 #2550

Closed

5 tasks

layershifter added 2 commits March 20, 2018 18:08

Merge branch 'master' into next

709c23a

feat(Icon): update SUI to 2.3 (#2665)

4a90965

Merge branch 'master' of https://github.com/Semantic-Org/Semantic-UI-…

9d0e2dd

…React into next # Conflicts: # docs/app/Views/Theming.js # yarn.lock

layershifter force-pushed the next branch 2 times, most recently from 79e6ea4 to 7ba8c3f Compare April 30, 2018 09:51

chore(gulp): remove task with icons

3efa80f

layershifter force-pushed the next branch from 7ba8c3f to 3efa80f Compare April 30, 2018 09:56

layershifter added 2 commits April 30, 2018 14:42

feat(Icon): regenerate icons

b07ac77

docs(Usage): add warning about SUIR versions

1cbb19b

layershifter changed the title ~~chore(package): update SUI to 2.3~~ BREAKING(package): update SUI to 2.3 Apr 30, 2018

layershifter added 2 commits April 30, 2018 14:55

docs(README): remove note

1933eaf

fix lint error

b7a2774

layershifter commented Apr 30, 2018

View reviewed changes

layershifter requested review from brianespinosa and levithomason April 30, 2018 12:04

layershifter added the ready for review label Apr 30, 2018

brianespinosa approved these changes Apr 30, 2018

View reviewed changes

brianespinosa mentioned this pull request Apr 30, 2018

Wrong Icon Name? #2617

Closed

Merge branch 'master' of https://github.com/Semantic-Org/Semantic-UI-…

5659fce

…React into next

levithomason mentioned this pull request May 6, 2018

feat(icon): Adding missing cog icon alias, fix SUI.js #2766

Closed

Merge branch 'master' of https://github.com/Semantic-Org/Semantic-UI-…

a846c78

…React into next # Conflicts: # src/index.js

levithomason added 2 commits May 31, 2018 16:17

merge master

89e0f36

fix(iconSearch): dedupe merged name sets

9ae4b76

levithomason added the ready for merge label May 31, 2018

levithomason approved these changes May 31, 2018

View reviewed changes

levithomason merged commit 500df9a into master May 31, 2018

levithomason deleted the next branch May 31, 2018 23:58

mihai-dinculescu mentioned this pull request Jun 6, 2018

fix(Modal): remove dimmer={false} #2882

Merged

traverse mentioned this pull request Jun 6, 2018

Portal: recent change breaks in IE11 #2886

Closed

bespokebob mentioned this pull request Jun 11, 2018

Update to SUIR 0.81 and SUI CSS 2.3 Tripwire/octagon#221

Closed

		@@ -1,5 +1,3 @@
		⚠️NOTE: Currently Semantic UI React is not yet compatible with the latest 2.3 version of Semantic UI styles. See [#2250](https://github.com/Semantic-Org/Semantic-UI-React/issues/2550) for more info.

Conversation

layershifter commented Mar 18, 2018 • edited by levithomason Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

BREAKING

This PR requieres usage of Semantic UI CSS >= 2.3.x

Uh oh!

codecov-io commented Mar 18, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

levithomason commented Mar 18, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghost commented Mar 20, 2018

Uh oh!

chuckhagy commented Mar 23, 2018

Uh oh!

layershifter commented Apr 16, 2018

Uh oh!

brianespinosa commented Apr 16, 2018

Uh oh!

layershifter commented Apr 30, 2018

Uh oh!

layershifter Apr 30, 2018

Choose a reason for hiding this comment

Uh oh!

layershifter Apr 30, 2018

Choose a reason for hiding this comment

Uh oh!

layershifter commented Apr 30, 2018

Uh oh!

levithomason commented May 6, 2018

Uh oh!

aminland commented May 22, 2018

Uh oh!

layershifter commented May 25, 2018

Uh oh!

levithomason commented May 31, 2018

Uh oh!

levithomason commented Jun 3, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

layershifter commented Mar 18, 2018 •

edited by levithomason

Loading

codecov-io commented Mar 18, 2018 •

edited

Loading

levithomason commented Mar 18, 2018 •

edited

Loading