feat(icon): Adding missing cog icon alias, fix SUI.js#2766
Closed
srbala wants to merge 2 commits intoSemantic-Org:masterfrom
srbala:feat/add-cog-icon
Closed
feat(icon): Adding missing cog icon alias, fix SUI.js#2766srbala wants to merge 2 commits intoSemantic-Org:masterfrom srbala:feat/add-cog-icon
srbala wants to merge 2 commits intoSemantic-Org:masterfrom
srbala:feat/add-cog-icon
Conversation
Cog icon (alias of single gear) is missing in current list
|
💖 Thanks for opening this pull request! 💖 Here is a list of things that will help get it across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
Codecov Report
@@ Coverage Diff @@
## master #2766 +/- ##
=======================================
Coverage 99.74% 99.74%
=======================================
Files 160 160
Lines 2762 2762
=======================================
Hits 2755 2755
Misses 7 7Continue to review full report at Codecov.
|
Author
|
Just realized that, it may be need SUI 2.3.x |
Member
Yep. This is done in our |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cog icon (alias of single gear) is missing in current list