Direct nbt component serialization#3860
Draft
Janmm14 wants to merge 5 commits intoSpigotMC:masterfrom
Draft
Conversation
Janmm14
force-pushed
the
direct-nbt-component-serialization
branch
3 times, most recently
from
0ee714a to
43854e3
Compare
Janmm14
commented
Jul 13, 2025
| { | ||
| context.deserialize( element, BaseComponent.class ) | ||
| } ); | ||
| return new Text( context.<BaseComponent>deserialize( element, BaseComponent.class ) ); |
Contributor
Author
There was a problem hiding this comment.
Should this change be in a separate PR?
Janmm14
force-pushed
the
direct-nbt-component-serialization
branch
2 times, most recently
from
52a66a7 to
8e47954
Compare
- stop mentioning null values - use shorter names - seamless integration of style's toString Also use just one string builder and keep track of whether a comma is needed before the next property.
…ded static qualifier
Janmm14
force-pushed
the
direct-nbt-component-serialization
branch
from
8e47954 to
3535dfb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Input needed on these things
Changes which will be done
Separate PR forComponentBuilder.shadowColorcreated: Add shadowColor to ComponentBuilder #3861. Once it is merged, I will rebase, so those changes are no longer in here. (It is in here atm because of a test using this).Closes #3852