Release 1.73 #421
Merged
Release 1.73 #421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add from mobile query parameter Add from mobile query parameter to the DeepLinkRouter's url. * Fix * Create Extensions group with folder * Fix * Remove appendFromMobileQueryParameter() * appendingQueryParameters
* removed join course string ab * removed test localizations
* Create group with folder * Split test * Fix * Respect current group * Do not request authorization before onboarding * Request authorization after onboarding * Request authorization for all users if they participants * Make decisions based on current group * Refactor rename isParticipant -> shouldShowOnFirstLaunch * Suggest streak
SunInJuly
approved these changes
Dec 3, 2018
* Add split test * Load progress * Add analytics * Move source * Refactor rename * Use only AchievementPopupAlertManager for presenting * Respect current group * Refactor rename isParticipant -> shouldShowAchievementPopup * Optional progress for AchievementViewData * Fix after merge conflict setSplitTestGroup * Fix foreground notification presentation Completes only with the sound when is in AB test group and with alert, sound when in control group * Fix remove Recovered References group * Fix alert not showing when in foreground for test group We should always call the completion hadnler with provided .alert and .sound options, because only after pressing on the notification notifications service will handleRemoteNotification.
* Fix custom alert presentation decision flow Present custom permission alert if delegate allowed, otherwise request authorization. * Format code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release 1.73 milestone
Main & Common