-
-
Notifications
You must be signed in to change notification settings - Fork 540
Ensure Nullability annotations for ListExtractor.java fields #1312
Copy link
Copy link
Labels
code qualityImprovements to the codebase to improve the code qualityImprovements to the codebase to improve the code qualitygood first issueEasy/simple issues perfect for newcomers to get involved in the projectEasy/simple issues perfect for newcomers to get involved in the projecthelp wantedHelp is wanted in fixing this issueHelp is wanted in fixing this issue
Metadata
Metadata
Assignees
Labels
code qualityImprovements to the codebase to improve the code qualityImprovements to the codebase to improve the code qualitygood first issueEasy/simple issues perfect for newcomers to get involved in the projectEasy/simple issues perfect for newcomers to get involved in the projecthelp wantedHelp is wanted in fixing this issueHelp is wanted in fixing this issue
Checklist
Affected version
0.24.6
Steps to reproduce the bug
The
ListExtractor.javacurrently do not expose the nullable fields using@Nullableannotations. Some use-sites might be able to get away with using these fields as non-null and lead to crashes, like TeamNewPipe/NewPipe#12401This could have been caught early on if the
ListExtractorfunction correctly indicated the nullable behavior of the returned value. Also, given the app is being rewritten in Kotlin, so the correct annotation would enforce the nullability handling at use-site.Expected behavior
The
ListExtractorshall correctly indicate the Nullable annotation for it's fieldsActual behavior
No response
Screenshots/Screen recordings
No response
Logs
No response
Additional information
No response