Skip to content

Add Nullable annotations in ListExtractor#1313

Merged
TobiGr merged 1 commit intoTeamNewPipe:devfrom
asifebrahim:temp
Jul 7, 2025
Merged

Add Nullable annotations in ListExtractor#1313
TobiGr merged 1 commit intoTeamNewPipe:devfrom
asifebrahim:temp

Conversation

@asifebrahim
Copy link
Copy Markdown
Contributor

Summary

This PR marks the nextPage field in InfoItemsPage<T> and ListExtractor<T> as @Nullable.
This improves compatibility with Kotlin consumers like the NewPipe app.

Motivation

Without this annotation, Kotlin treats nextPage as non-null, which may lead to incorrect assumptions when no further page exists.

Notes

  • Only annotations were added. No logic was changed.
  • Local tests were run (./gradlew test) and failures are due to unrelated issues (e.g., YouTube JS changes, geo-restrictions).

Related Issue

Fixes #1312

@AudricV AudricV changed the title Added the @Nullable annotaions in ListExtractor.java Add Nullable annotaions in ListExtractor Jul 6, 2025
@AudricV AudricV changed the title Add Nullable annotaions in ListExtractor Add Nullable annotations in ListExtractor Jul 6, 2025
@ShareASmile ShareASmile added the code quality Improvements to the codebase to improve the code quality label Jul 6, 2025
Copy link
Copy Markdown
Contributor

@TobiGr TobiGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@TobiGr TobiGr merged commit 48d7820 into TeamNewPipe:dev Jul 7, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code quality Improvements to the codebase to improve the code quality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ensure Nullability annotations for ListExtractor.java fields

3 participants