check for uid gid conflicts across entire LDAP tree #248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonLeary42
force-pushed
the
main
branch
6 times, most recently
from
021a1af to
969c0ad
Compare
simonLeary42
force-pushed
the
fix-uid-conflict
branch
from
e0accce to
855f6a4
Compare
simonLeary42
changed the title
simonLeary42
force-pushed
the
fix-uid-conflict
branch
3 times, most recently
from
0f5df88 to
f4b835d
Compare
simonLeary42
changed the title
simonLeary42
force-pushed
the
fix-uid-conflict
branch
7 times, most recently
from
0adfec7 to
910b9b2
Compare
simonLeary42
force-pushed
the
fix-uid-conflict
branch
from
910b9b2 to
1abd55b
Compare
Collaborator
Author
|
should be refactored to use the new functionality from #266 |
simonLeary42
force-pushed
the
fix-uid-conflict
branch
from
1abd55b to
2767d68
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of checking the
uidnumbers in theusersOU and thegidnumbersin thegroups,org_groups,pi_groupsOUs,UnityLDAP::IDNumInUsenow checks theuidnumbers andgidnumbersin the entire LDAP tree. Also, while choosing an ID for a new user, LDAP is queried only once instead of once-per-iteration-of-while-loop.