Skip to content

Conversation

@simonLeary42
Copy link
Collaborator

@simonLeary42 simonLeary42 commented Jun 17, 2025

  • added custom mapping IDs to getIDNumsInUse so that they won't be allocated to any other new users
  • added warnings
    • custom mapping ID already taken
    • non-csv file in custom user mapping directory ignored
  • refactor
    • instead of getUnassignedID wrapping around getNexxtUIDNumber, getNextUIDNumber wraps around getUnassignedID.
    • since UnityGroup uses getNextPIGIDNumber and UnityOrg uses getNextOrgGIDNumber, UnityUser should use getNextUIDNumber.
  • change confusing variable name
    • uid_match -> uidnumber (it's not matching anything, and it's not a uid)
    • netid_match -> match (it's not strictly netid, it could be netid or uid)
  • style

should be merged after #248

see actual changes

  • TODO document custom mappings
  • TODO write tests
    • user with custom mapping should get it
    • custom mapped ID should not be given to any other new user

@simonLeary42 simonLeary42 force-pushed the rewrite-custom-user-mapping branch 2 times, most recently from 37f33d5 to be7c233 Compare June 17, 2025 13:52
@simonLeary42 simonLeary42 marked this pull request as draft June 17, 2025 14:10
@simonLeary42 simonLeary42 force-pushed the rewrite-custom-user-mapping branch 6 times, most recently from af17901 to 79557ce Compare June 17, 2025 15:09
@simonLeary42 simonLeary42 force-pushed the rewrite-custom-user-mapping branch from 79557ce to a0c4d81 Compare June 17, 2025 16:41
@simonLeary42 simonLeary42 force-pushed the rewrite-custom-user-mapping branch from aa72c03 to 56f0151 Compare June 17, 2025 16:56
@simonLeary42
Copy link
Collaborator Author

superceded by #286

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants