Improve CONTRIBUTING.md as per April Community Call discussion.#985
Merged
jamesmisson merged 5 commits intoUniversalViewer:devfrom Jul 22, 2024
Merged
Conversation
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Contributor
Author
|
I think more discussion is needed on the release process -- particularly whether we bump the version in the dev branch before merging to main, or if we need to merge main back into dev after bumping the version. I can see arguments for or against either approach. |
Contributor
|
Thanks @demiankatz, I think these are all improvements, I'll go ahead and merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed on today's Community Call, this PR makes some improvements to CONTRIBUTING.md to make it more helpful. It adjusts heading levels for consistency, adds a note about the destination of the distribution build, explains our Git workflows, removes some old comments, and includes a few other minor adjustments.
Feedback is welcome!