Skip to content

AF-2937 Add hooks to support tracing#195

Merged
aaronlademann-wf merged 4 commits intomasterfrom
tracing_for_real
Oct 30, 2018
Merged

AF-2937 Add hooks to support tracing#195
aaronlademann-wf merged 4 commits intomasterfrom
tracing_for_real

Conversation

@greglittlefield-wf
Copy link
Contributor

Ultimate problem:

I forgot to add the core changes I needed in #193 🤦‍♂️

How it was fixed:

Also fixed test setup for changes I made in #193:

  • 0a7f393 "Make stateful test components actually stateful >_>"

Testing suggestions:

  • Verify tests pass

Potential areas of regression:

Flux component store subscriptions


FYA: @greglittlefield-wf @aaronlademann-wf @kealjones-wk @evanweible-wf @maxwellpeterson-wf

@greglittlefield-wf greglittlefield-wf requested a review from a team as a code owner October 23, 2018 22:47
@aviary-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on HipChat: InfoSec Forum.

/// These subscriptions are canceled when the component is unmounted.
List<StreamSubscription> _subscriptions = [];

// This is private and called by classes to work around super-calls not being supported in mixins
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whitespace-agnostic diff in this file may help when reviewing

@rmconsole6-wk rmconsole6-wk changed the title Add hooks to support tracing AF-2937 Add hooks to support tracing Oct 23, 2018
@codecov-io
Copy link

Codecov Report

Merging #195 into master will increase coverage by 0.27%.
The diff coverage is 90.91%.

@@            Coverage Diff             @@
##           master     #195      +/-   ##
==========================================
+ Coverage   94.27%   94.53%   +0.27%     
==========================================
  Files          34       34              
  Lines        1640     1645       +5     
==========================================
+ Hits         1546     1555       +9     
+ Misses         94       90       -4

///
/// Override to set up custom listener behavior.
@protected
void listenToStoreForRedraw(Store store) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this have @mustCallSuper as well?

Copy link
Contributor Author

@greglittlefield-wf greglittlefield-wf Oct 24, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question. No, since there are some cases where the listening setup might use a different mechanism.

Here's an example override

  @override
  void listenToStoreForRedraw(Store store) {
    if (store is TracedStore) {
      listenToStream(store.streamWithPayload, handleRedrawOnWithPayload);
    } else {
      super.listenToStoreForRedraw(store);
    }
  }

aaronlademann-wf and others added 2 commits October 24, 2018 09:13
Co-Authored-By: greglittlefield-wf <greg.littlefield@workiva.com>
Co-Authored-By: greglittlefield-wf <greg.littlefield@workiva.com>
@aaronlademann-wf
Copy link
Contributor

+1

@aaronlademann-wf aaronlademann-wf merged commit a23f407 into master Oct 30, 2018
@aaronlademann-wf aaronlademann-wf deleted the tracing_for_real branch October 30, 2018 13:15
@kealjones-wk
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants