AF-2937 Add hooks to support tracing#195
Merged
aaronlademann-wf merged 4 commits intomasterfrom Oct 30, 2018
Merged
Conversation
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on HipChat: InfoSec Forum. |
| /// These subscriptions are canceled when the component is unmounted. | ||
| List<StreamSubscription> _subscriptions = []; | ||
|
|
||
| // This is private and called by classes to work around super-calls not being supported in mixins |
Contributor
Author
There was a problem hiding this comment.
Whitespace-agnostic diff in this file may help when reviewing
Codecov Report
@@ Coverage Diff @@
## master #195 +/- ##
==========================================
+ Coverage 94.27% 94.53% +0.27%
==========================================
Files 34 34
Lines 1640 1645 +5
==========================================
+ Hits 1546 1555 +9
+ Misses 94 90 -4 |
| /// | ||
| /// Override to set up custom listener behavior. | ||
| @protected | ||
| void listenToStoreForRedraw(Store store) { |
Contributor
There was a problem hiding this comment.
Should this have @mustCallSuper as well?
Contributor
Author
There was a problem hiding this comment.
Good question. No, since there are some cases where the listening setup might use a different mechanism.
Here's an example override
@override
void listenToStoreForRedraw(Store store) {
if (store is TracedStore) {
listenToStream(store.streamWithPayload, handleRedrawOnWithPayload);
} else {
super.listenToStoreForRedraw(store);
}
}Co-Authored-By: greglittlefield-wf <greg.littlefield@workiva.com>
Co-Authored-By: greglittlefield-wf <greg.littlefield@workiva.com>
Contributor
|
+1 |
Contributor
|
+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ultimate problem:
I forgot to add the core changes I needed in #193 🤦♂️
How it was fixed:
Also fixed test setup for changes I made in #193:
Testing suggestions:
Potential areas of regression:
Flux component store subscriptions