Skip to content

AF-2888 Accommodate tracing of Store triggers and resulting redraws#120

Merged
rmconsole7-wk merged 2 commits intomasterfrom
tracing_rebased
Oct 18, 2018
Merged

AF-2888 Accommodate tracing of Store triggers and resulting redraws#120
rmconsole7-wk merged 2 commits intomasterfrom
tracing_rebased

Conversation

@greglittlefield-wf
Copy link
Contributor

Ultimate Problem

To implement tracing of Flux components in https://github.com/Workiva/app_intelligence_dart/pull/737, we needed a way to:

  • know whether a call to redraw was triggered from a store handler, and know which store triggered the redraw
  • set up a custom default handler for certain types of stores

Solution

  • Add lifecycle methods to allow subclasses to safely hook into and override store redraw logic:
    • listenToStoreForRedraw
      • See example override here
    • handleRedrawOn
      • See exampleoverride here
  • Add Tests

Testing

  • Verify tests pass
  • Smoke test examples

@dustinlessard-wf @kealjones-wk @evanweible-wf
@aaronlademann-wf @kealjones-wk

@aviary2-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on HipChat: InfoSec Forum.

dart:
- stable
- dev
- 1.24.3
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was needed to get a passing build now that Dart 2 is stable

@rm-astro-wf rm-astro-wf changed the title Accommodate tracing of Store triggers and resulting redraws AF-2888 Accommodate tracing of Store triggers and resulting redraws Oct 16, 2018
@kealjones-wk
Copy link
Contributor

kealjones-wk commented Oct 18, 2018

QA +1

  • Testing instruction
  • Dev +1's
  • Dev/QA +10 with detail of what was tested
    • Verify tests pass
    • Smoke test examples
  • Unit tests created/updated
  • All unit tests pass
  • Rosie has run and reports properly the release the ticket will be included in

Merging into master.

@kealjones-wk
Copy link
Contributor

@Workiva/release-management-pp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants