FED-7 Move over uiJsComponent + tests #743
Merged
rmconsole5-wk merged 31 commits intomasterfrom May 12, 2022
Merged
Conversation
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
Co-authored-by: brianphillips-wk <brianphillips-wk@users.noreply.github.com>
Contributor
I noted some weird test failures ultimately caused by WeakMap not initializing properly, causing issues where `_dartRefForJsRef` is used:Digging in... Edit: fixed in 4329621 |
Also, cleanup: don't use `factory`, which doesn't seem to make a difference but isn't what the docs say to use when instantiating non-anonymous objects.
greglittlefield-wf
previously requested changes
May 11, 2022
Contributor
greglittlefield-wf
left a comment
There was a problem hiding this comment.
Just one thing around the use of style in tests (and some #nits, but don't forget that addressing those is optional), otherwise this looks good to go!
Co-authored-by: Greg Littlefield <greg.littlefield@workiva.com>
Co-authored-by: Greg Littlefield <greg.littlefield@workiva.com>
All set for a final look
greglittlefield-wf
approved these changes
May 12, 2022
Contributor
greglittlefield-wf
left a comment
There was a problem hiding this comment.
+10
@Workiva/release-management-p
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
We want to expose uiJsComponent and an assortment of utilities so that other teams can easily wrap JS components.
Changes
Copy uiJsComponent and prop conversion utils to over_react
Copy tests to over_react
Release Notes
Review
See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.
Please review:
QA Checklist
Merge Checklist
While we perform many automated checks before auto-merging, some manual checks are needed: