Skip to content

RM-144900 RM-144899 Release over_react 4.4.0#760

Merged
rmconsole6-wk merged 4 commits intomasterfrom
release_over_react_4.4.0
Jun 15, 2022
Merged

RM-144900 RM-144899 Release over_react 4.4.0#760
rmconsole6-wk merged 4 commits intomasterfrom
release_over_react_4.4.0

Conversation

@rmconsole-readonly-wk
Copy link
Contributor

@rmconsole-readonly-wk rmconsole-readonly-wk commented Jun 10, 2022

Full changelog entry:

4.4.0

  • #743 Add js_component.dart entrypoint with utilities for wrapping JS React components. More in-depth documentation around how to use these APIs and best practices is coming soon.

Analyzer Plugin

  • Fix diagnostics not working in Dart >=2.13, by upgrading to analyzer_plugin 0.6.0
  • Diagnostics can be configured with custom severity, including disabling them (docs)
  • New diagnostics:
    • over_react_create_ref_usage - Warns when using createRef in a function component instead of useRef
    • over_react_non_defaulted_prop - Warns when using a prop in a function component instead of a local variable that defaults the prop
    • over_react_rules_of_hooks - Warns when calling hooks conditionally or using hooks outside of function components or custom hook functions
    • over_react_style_camel_case - Warns when using non-camelCased keys in style maps, which get ignored by React
  • New assists:
    • Convert between function and class component syntax (only moves code around and doesn't migrate lifecycle methods, state, hooks, etc.)
  • Improvements to existing features:
    • over_react_invalid_render_return_type - Update to work with function components
    • over_react_duplicate_prop_cascade - Fix duplicate DOM props not linting in certain cases
    • "Add ref" assist and ref object quick fixes - Update to work with function components
  • Migrate most code to null safety, fix several potential null errors
  • Improve test coverage

Pull Requests included in release:

Requested by: @greglittlefield-wf

Diff Between Last Tag and Proposed Release: 4.3.1...Workiva:release_over_react_4.4.0
Diff Between Last Tag and New Tag: 4.3.1...4.4.0

The logs for the request that created this PR can be found here
This pull request can be recreated by clicking here

@rmconsole2-wf rmconsole2-wf changed the title Release over_react 4.4.0 RM-144900 RM-144899 Release over_react 4.4.0 Jun 10, 2022
@aviary-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

Copy link
Contributor

@aaronlademann-wf aaronlademann-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Comment on lines -20 to +23
static const convertToClass = AssistKind('convertToClass', 30, _convertToClassDesc);
static const convertToClass = AssistKind('convertToClass', 40, _convertToClassDesc);

@DocsMeta(_convertToFunctionDesc, details: _convertToFunctionDetails)
static const convertToFunction = AssistKind('convertToFunction', 30, _convertToFunctionDesc);
static const convertToFunction = AssistKind('convertToFunction', 40, _convertToFunctionDesc);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I lowered the priority of these (higher number = lower priority) since they were showing up before more commonly-used assists like add ref / add props

Copy link
Contributor

@aaronlademann-wf aaronlademann-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@greglittlefield-wf
Copy link
Contributor

QA +1
@Workiva/release-management-p

Copy link

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

@rmconsole6-wk rmconsole6-wk merged commit 915cdc6 into master Jun 15, 2022
@rmconsole6-wk rmconsole6-wk deleted the release_over_react_4.4.0 branch June 15, 2022 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants