Bug Fix for #12111 and #12144

[swmitra]

This PR fixes the file close issue.

[swmitra]

ping @ficristo @petetnt @abose Can you guys please confirm the fix using this branch.

[petetnt]

Fixes #12111 and #12144. Working set items close correctly and integration tests pass.

On related note, why is the event variable a global on src/project/FileViewController.js? Seems... weird?

[swmitra]

@petetnt This "event" handle is from the global context. If the the current execution frame is a result of an event triggered by user or system , this handle is always set at the global context. As the actual event handle is never passed through the call stack , I have used the global handle to verify the context.

[petetnt]

Thanks for the explanation @swmitra 👍

[abose]

@swmitra three document integration integration tests are failing with this PR.

[ficristo]

@abose If you are referring to the Document Integration tests they are failing on master too.

@abose @swmitra Are you going to fix all the tests in this PR? Otherwise can you land this? It will be a bit easier to see the other failures.

[Siphon880gh]

Hey guys, how do I get this release with the CMD+W bug fix? There hasn't been a release uploaded here:
https://github.com/adobe/brackets/releases

Could I clone it to my computer using git? How do I compile it for Mac afterwards? Thanks.

[petetnt]

Hi @Siphon880gh,

there's a guide called How to hack on Brackets, which takes you through step by step on how to use a development build of Brackets (no building needed, just using git and running an single tool).

After you have a dev build running you'll need to merge this branch. For example on git commandline:

git fetch upstream swmitra/BugFixesFor1.6
git merge upstream/swmitra/BugFixesFor1.6

Restart Brackets and the fix should be applied and working

[swmitra]

Re-Targeting to release branch.

[Siphon880gh]

Thanks!

[abose]

A build refresh is scheduled by his week or next for 1.6and after that the new installers posted will contain this patch.

[schroef]

Srry for asking, im kinda a new to this all.. is also see this error with file not closing in the tree list. Im using v1.6 rev1.6.0-16680 on osx 10.11.4

[n0nag0n]

I installed this like......3-4 days ago, checked if there was an update (which it says there isn't) and I'm having the same issue. On a Mac, El Capitan with Release 1.6 build 1.6.0-16680 (release 3df0ac6) installed.