Skip to content

feat(#510): enforce thesis confidence rules#548

Merged
adolago merged 1 commit intomainfrom
issue-510-thesis-confidence-rules
Mar 15, 2026
Merged

feat(#510): enforce thesis confidence rules#548
adolago merged 1 commit intomainfrom
issue-510-thesis-confidence-rules

Conversation

@adolago
Copy link
Copy Markdown
Owner

@adolago adolago commented Mar 15, 2026

Summary

  • require evidence links for every persisted thesis revision and store the applied confidence assessment on the revision and current thesis record
  • add thesis-confidence.v1 to cap conviction from evidence coverage, tool diversity, and linked valuation context while surfacing the rule in thesis snapshots
  • document the confidence policy and extend thesis-ledger tests and telemetry for evidence enforcement and conviction downgrades

Testing

  • bash scripts/bun-audit-ci.sh
  • bash scripts/verify-skills.sh
  • bun run --cwd packages/zee typecheck
  • cd packages/zee && bun test test/investing/thesis-ledger.test.ts test/investing/research-executor.test.ts
  • cd packages/zee && CI=true bun test --reporter=dots --coverage-reporter=lcov
  • cd packages/zee && bun run build
  • cd packages/zee && ./script/verify-binary.sh
  • zee investing thesis status --json

Closes #510

@adolago adolago merged commit ca5ecf8 into main Mar 15, 2026
5 of 6 checks passed
@adolago adolago deleted the issue-510-thesis-confidence-rules branch March 15, 2026 15:13
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3f55f8ba94

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +533 to +534
requestedConviction: input.conviction,
priorConviction: existing?.conviction,
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve original requested conviction in confidence telemetry

recordInvestingThesisRevision now re-evaluates confidence from input.conviction, but the thesis-refresh automation passes draft.conviction (already capped by the first confidence pass) into this function, so persisted confidence.requestedConviction is flattened to the already-downgraded value. In scenarios where an existing thesis carries high conviction and new evidence only supports medium/low, the stored confidence block and investing.thesis.confidence event no longer record that a downshift occurred, which breaks the new audit trail semantics for requested vs applied conviction.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[child] evidence-linked thesis updates and confidence rules

1 participant