Fetching prebuilt mauve jar rather than building our own#6753
Fetching prebuilt mauve jar rather than building our own#6753smlambert merged 5 commits intoadoptium:masterfrom
Conversation
Signed-off-by: Adam Farley <adfarley@ibm.com>
There was a problem hiding this comment.
I believe that since adoptium/TKG@87c75ad we can remove the if( params.BUILD_TYPE == "systemtest" ) block all together, or at least modify it to call getDependencies.pl with the systemtest parameter, but would like to test it. Can you please try that first, before we proceed to patching this in this way?
Signed-off-by: Adam Farley <adfarley@ibm.com>
Signed-off-by: Adam Farley <adfarley@ibm.com>
Signed-off-by: Adam Farley <adfarley@ibm.com>
Sure. I've changed the code to do that, and it downloads the dependencies as it should. https://ci.adoptium.net/job/systemtest.getDependency/261/ Note: This PR is now linked (well, more linked) to adoptium/TKG#778 |
|
Also wondered in this case is it sill necessary to separate systemtest.getDependency job from test.getDependency job considering job configuration is kindly identical? Having two separate jobs can isolate failures but may increase resource usage and maintenance efforts. |
Signed-off-by: Adam Farley <adfarley@ibm.com>
No, though I'd recommend keeping the former job around until after January release. I'm also wary of scope creep here, so I've raised a new issue to cover merging the two jobs. |
smlambert
left a comment
There was a problem hiding this comment.
thanks @adamfarley
FYI @pshipton - We believe this will work for all Jenkins servers (have checked on a couple of ours), but please msg me if hyc or others affected negatively.
|
Thanks @smlambert and @sophia-guo 😎 |
Because the mauve building process is currently broken.
Tested here: https://ci.adoptium.net/job/systemtest.getDependency/256/ - pass