Skip to content

Fetching prebuilt mauve jar rather than building our own#6753

Merged
smlambert merged 5 commits intoadoptium:masterfrom
adamfarley:redirect_mauve_fetch_to_prebuilt_jar
Dec 3, 2025
Merged

Fetching prebuilt mauve jar rather than building our own#6753
smlambert merged 5 commits intoadoptium:masterfrom
adamfarley:redirect_mauve_fetch_to_prebuilt_jar

Conversation

@adamfarley
Copy link
Copy Markdown
Contributor

@adamfarley adamfarley commented Nov 27, 2025

Because the mauve building process is currently broken.

Tested here: https://ci.adoptium.net/job/systemtest.getDependency/256/ - pass

Signed-off-by: Adam Farley <adfarley@ibm.com>
Copy link
Copy Markdown
Contributor

@smlambert smlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that since adoptium/TKG@87c75ad we can remove the if( params.BUILD_TYPE == "systemtest" ) block all together, or at least modify it to call getDependencies.pl with the systemtest parameter, but would like to test it. Can you please try that first, before we proceed to patching this in this way?

Signed-off-by: Adam Farley <adfarley@ibm.com>
Signed-off-by: Adam Farley <adfarley@ibm.com>
Signed-off-by: Adam Farley <adfarley@ibm.com>
@adamfarley
Copy link
Copy Markdown
Contributor Author

we can remove the if( params.BUILD_TYPE == "systemtest" ) block all together, or at least modify it to call getDependencies.pl with the systemtest parameter

Sure. I've changed the code to do that, and it downloads the dependencies as it should.

https://ci.adoptium.net/job/systemtest.getDependency/261/
https://ci.adoptium.net/job/test.getDependency/2676/

Note: This PR is now linked (well, more linked) to adoptium/TKG#778

@sophia-guo
Copy link
Copy Markdown
Contributor

Also wondered in this case is it sill necessary to separate systemtest.getDependency job from test.getDependency job considering job configuration is kindly identical? Having two separate jobs can isolate failures but may increase resource usage and maintenance efforts.

Signed-off-by: Adam Farley <adfarley@ibm.com>
@adamfarley
Copy link
Copy Markdown
Contributor Author

... is it still necessary to separate systemtest.getDependency job from test.getDependency job...

No, though I'd recommend keeping the former job around until after January release.

I'm also wary of scope creep here, so I've raised a new issue to cover merging the two jobs.

#6760

@karianna karianna requested a review from smlambert December 2, 2025 23:25
Copy link
Copy Markdown
Contributor

@smlambert smlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @adamfarley

FYI @pshipton - We believe this will work for all Jenkins servers (have checked on a couple of ours), but please msg me if hyc or others affected negatively.

@smlambert smlambert merged commit afbb849 into adoptium:master Dec 3, 2025
2 checks passed
@adamfarley
Copy link
Copy Markdown
Contributor Author

Thanks @smlambert and @sophia-guo 😎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants