Updating getDependencies to use maven server for downloading asm.jar

[adamfarley]

Test runs:

• https://ci.adoptium.net/job/systemtest.getDependency/265/ - pass
• https://ci.adoptium.net/job/test.getDependency/2675/ - pass

Linked PR:

• Fetching prebuilt mauve jar rather than building our own aqa-tests#6753

[llxia]

@annaibm could you please review?

[adamfarley]

Note: This PR is now linked to adoptium/aqa-tests#6753 and should be merged around the same time to prevent conflict. See the comments in that PR for details.

[smlambert]

Changing my review, since more commits have come in to this PR since I reviewed it.

[smlambert]

@adamfarley - I do not think you need to make the additional changes you have added, please take a look at this code
https://github.com/adoptium/aqa-tests/blob/master/buildenv/jenkins/JenkinsfileBase#L226-L229

To see how you can update adoptium/aqa-tests#6753

[sophia-guo]

Also see https://github.com/adoptium/TKG/blob/master/scripts/getDependencies.pl#L286

[adamfarley]

Ok, I've reviewed the links provided and I've amended the code in a way that covers both use cases (and removes the unnecessary argument).

Let me know if this works for you.

[annaibm]

@adamfarley Could you add the related issue link to the PR description? It would help provide the background and make it easier to follow. Thanks!

[sophia-guo]

Originally dir systemtest_prereqs stays because systemtest jars are generated by system test build.xml systemtest_prereqs and archived with the directory.

SYSTEM_LIB_DIR is the location for all system tests dependencies keeping dir systemtest_prereqs is unnecessary. https://github.com/adoptium/TKG/blob/master/scripts/getDependencies.pl#L332 can be removed. And this https://github.com/adoptium/TKG/pull/778/files#diff-6548ada249042f87589ac5683c2f76bd9b8447695fd19fd02ad3030a2592b775R320-R322 is not necessary.

This tools.jar https://github.com/adoptium/TKG/blob/master/scripts/getDependencies.pl#L279 should also move to https://github.com/adoptium/aqa-triage-data/blob/main/AQAvit/

[adamfarley]

SYSTEM_LIB_DIR is the location for all system tests dependencies keeping dir systemtest_prereqs is unnecessary.

SYSTEM_LIB_DIR doesn't appear to be in-use in the TKG repository. I see that aqa-tests does have it, but I'm not sure we want TKG to have a dependency on aqa-tests.

This tools.jar https://github.com/adoptium/TKG/blob/master/scripts/getDependencies.pl#L279 should also move to https://github.com/adoptium/aqa-triage-data/blob/main/AQAvit/

That sounds like something we should explore in a separate issue.

I've raised one here: #782

[sophia-guo]

LGTM. Enhancement or clean up is tracked by a separate issue.

[adamfarley]

Thanks @smlambert @sophia-guo @annaibm and @karianna 😎