pbTests: Synchronise branch specification in VPC & QPC#1962
Merged
Willsparker merged 4 commits intoadoptium:masterfrom Mar 2, 2021
Merged
pbTests: Synchronise branch specification in VPC & QPC#1962Willsparker merged 4 commits intoadoptium:masterfrom
Willsparker merged 4 commits intoadoptium:masterfrom
Conversation
Contributor
Author
|
https://ci.adoptopenjdk.net/job/VagrantPlaybookCheck/1087/ Got it to work! Coming out of draft |
5 tasks
sxa
reviewed
Mar 1, 2021
| awk '{print}/^\[defaults\]$/{print "private_key_file = id_rsa"; print "remote_tmp = $HOME/.ansible/tmp"; print "timeout = 30"}' < ansible.cfg > ansible.cfg.tmp && mv ansible.cfg.tmp ansible.cfg | ||
|
|
||
| ansible-playbook -i playbooks/AdoptOpenJDK_Unix_Playbook/hosts.unx -u vagrant -b --skip-tags adoptopenjdk,jenkins${skipFullSetup} playbooks/AdoptOpenJDK_Unix_Playbook/main.yml 2>&1 | tee $WORKSPACE/adoptopenjdkPBTests/logFiles/$folderName.$branchName.$OS.log | ||
| ansible-playbook -i playbooks/AdoptOpenJDK_Unix_Playbook/hosts.unx -u vagrant -b --skip-tags adoptopenjdk,jenkins${skipFullSetup} playbooks/AdoptOpenJDK_Unix_Playbook/main.yml 2>&1 | tee $WORKSPACE/adoptopenjdkPBTests/logFiles/$gitFork.$gitBranch.$OS.log |
Member
There was a problem hiding this comment.
Possibly use ${gitFork}.${gitBranch} here for consistency with other changes you've made in the file
Member
|
Running this myself to see if it works ... |
gdams
approved these changes
Mar 1, 2021
sxa
approved these changes
Mar 1, 2021
Member
sxa
left a comment
sxa
left a comment
There was a problem hiding this comment.
Running this myself to see if it works ...
Seemed ok until I lost my connect to the server it was running on which has nothing to do with this PR ... So I'll approve
This was referenced Apr 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #1941
VPC now specifies branches in the same way as QPC, because I think it's much cleaner. Fringe benefit, now VPC can test branches that have
/in the name. Also just cleaned up the code a little bit.Checklist