pbTests: Fixup buildJDK arguments in QPC & export buildJDK vars#2132
Merged
Willsparker merged 1 commit intoadoptium:masterfrom Apr 16, 2021
Merged
pbTests: Fixup buildJDK arguments in QPC & export buildJDK vars#2132Willsparker merged 1 commit intoadoptium:masterfrom
Willsparker merged 1 commit intoadoptium:masterfrom
Conversation
sxa
approved these changes
Apr 15, 2021
Member
sxa
left a comment
There was a problem hiding this comment.
Looks ok so I'm happy for you to merge this if this has been tested and works, although I'm somewhat surprised this ever worked if the variables weren't being exported
Contributor
Author
So am I ... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref: #2121
Currently QPC is failing on a few platforms that should be stable. It was due to #1962 not updating the script to reflect
buildJDK.sh's arguments. Amazing how the author of that PR didn't realise .. 👀 .In my testing, I noticed that often the
make-adopt-build-farm.shwouldn't pickup on variables that were being set as part ofbuildJDK.sh. When the build scripts started defaulting most arguments, This just needed those variables exported. I've gone back to makingopenj9the default as this tests more dependencies for our playbooks.Checklist