[ENH] Type hints for primitives and string arguments:Part1#1472
[ENH] Type hints for primitives and string arguments:Part1#1472TonyBagnall merged 6 commits intoaeon-toolkit:mainfrom nileenagp:main
Conversation
Thank you for contributing to
|
|
All the checks are passed successfully. Please review. |
TonyBagnall
left a comment
There was a problem hiding this comment.
LGTM, thanks for the PR
MatthewMiddlehurst
left a comment
There was a problem hiding this comment.
The current ones here do not match the docstring currently as well I'm pretty sure.
n_jobs could be Optional[int] (defaults to None)
distance and weights could be Union[str, Callable] (accepts functions)
Reference Issues/PRs
Fixes #1454
What does this implement/fix? Explain your changes.
Adding type hints to 2 methods in the script: aeon.classification.distance_based._time_series_neighbors.
Methods are : init(), get_test_params()
Does your contribution introduce a new dependency? If yes, which one?
None
Any other comments?
Type hints are NOT added in other methods since they were not primitive types.