Skip to content

[ENH] Type hints for primitives and string arguments:Part1 #1472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TonyBagnall merged 6 commits into from
Apr 25, 2024
Merged

[ENH] Type hints for primitives and string arguments:Part1 #1472

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3fbeb6c
Updated 2 functions in _time_series_neighbors.py for including type h…
Apr 23, 2024
c5bd3c6
Updated 2 functions in _time_series_neighbors.py for including type h…
nileenagp Apr 23, 2024
440cb94
Merge branch 'main' of https://github.com/nileenagp/aeon into main
nileenagp Apr 23, 2024
d663a3d
Updated 2 functions in _time_series_neighbors.py for including type h…
nileenagp Apr 23, 2024
07b46c5
Fixes for failing tests in PR
nileenagp Apr 25, 2024
53c6c28
Fix for pre-commit isort
nileenagp Apr 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions aeon/classification/distance_based/_time_series_neighbors.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@
__maintainer__ = []
__all__ = ["KNeighborsTimeSeriesClassifier"]

from typing import List

import numpy as np

from aeon.classification.base import BaseClassifier
Expand Down Expand Up @@ -69,12 +71,12 @@ class KNeighborsTimeSeriesClassifier(BaseClassifier):

def __init__(
self,
distance="dtw",
distance_params=None,
n_neighbors=1,
weights="uniform",
n_jobs=1,
):
distance: str = "dtw",
distance_params: dict = None,
n_neighbors: int = 1,
weights: str = "uniform",
n_jobs: int = 1,
) -> None:
self.distance = distance
self.distance_params = distance_params
self.n_neighbors = n_neighbors
Expand Down Expand Up @@ -214,7 +216,7 @@ def _kneighbors(self, X):
return closest_idx, ws

@classmethod
def get_test_params(cls, parameter_set="default"):
def get_test_params(cls, parameter_set: str = "default") -> List[dict]:
"""Return testing parameter settings for the estimator.

Parameters
Expand Down