[ENH] Added load_model functionality to InceptionTimeRegressor and LITETimeRegressor#2772
[ENH] Added load_model functionality to InceptionTimeRegressor and LITETimeRegressor#2772Ramana-Raja wants to merge 5 commits into
Conversation
Thank you for contributing to
|
There was a problem hiding this comment.
Thanks for this.
Can you please see how its done for inceptionTime classifier and do as such?
Function should not take as parameter a "cls" it takes self and creates an instance inside.
https://github.com/aeon-toolkit/aeon/blob/main/aeon/classification/deep_learning/_inception_time.py
Functionality should be the same for regressors
Could you also resolve conflict ?
|
i think we can close this @MatthewMiddlehurst given #3130 |
|
Hi yes this has been completed elsewhere and there are conflicts on this. |
Reference Issues/PRs
#2770
What does this implement/fix? Explain your changes.
Added load_model functionality to InceptionTimeRegressor and LITETimeRegressor
Does your contribution introduce a new dependency? If yes, which one?
No
Any other comments?
PR checklist
For all contributions
For new estimators and functions
__maintainer__at the top of relevant files and want to be contacted regarding its maintenance. Unmaintained files may be removed. This is for the full file, and you should not add yourself if you are just making minor changes or do not want to help maintain its contents.For developers with write access